[xfhell] Fix FTBFS with -Werror=format-security (#1037396, #1107276)

Yaakov Selkowitz yselkowitz at fedoraproject.org
Tue Jul 8 03:21:47 UTC 2014


commit ef121409ea4e19fa629561b6988fdda0d9b0b79a
Author: Yaakov Selkowitz <yselkowi at redhat.com>
Date:   Fri Jun 20 16:05:42 2014 -0500

    Fix FTBFS with -Werror=format-security (#1037396, #1107276)

 xfhell-1.9-format-security.patch |   13 +++++++++++++
 xfhell.spec                      |    8 +++++++-
 2 files changed, 20 insertions(+), 1 deletions(-)
---
diff --git a/xfhell-1.9-format-security.patch b/xfhell-1.9-format-security.patch
new file mode 100644
index 0000000..53b8a84
--- /dev/null
+++ b/xfhell-1.9-format-security.patch
@@ -0,0 +1,13 @@
+diff --git a/src/utils.c b/src/utils.c
+index b2dfcc3..ff76b98 100644
+--- a/src/utils.c
++++ b/src/utils.c
+@@ -827,7 +827,7 @@ Save_Pixbuf( void )
+ 	  "jpeg", &error, "quality", "75", NULL );
+   if( error != NULL )
+   {
+-	fprintf( stderr, error->message );
++	fprintf( stderr, "%s", error->message );
+ 	Error_Dialog( "Failed to save Receive pixbuf\n", FALSE );
+   }
+ 
diff --git a/xfhell.spec b/xfhell.spec
index 3f8b6d6..407bec6 100644
--- a/xfhell.spec
+++ b/xfhell.spec
@@ -1,6 +1,6 @@
 Name:           xfhell
 Version:        1.9
-Release:        12%{?dist}
+Release:        13%{?dist}
 Summary:        GTK based Ham Radio application for the Hellschreiber communications mode
 
 Group:          Applications/Communications
@@ -11,6 +11,8 @@ Source0:        http://5b4az.chronos.org.uk/pkg/%{name}/%{name}-%{version}.tar.g
 Source1:        %{name}.desktop
 #temporary Icon
 Source2:        %{name}.png
+# -Werror=format-security
+Patch0:         xfhell-1.9-format-security.patch
 
 BuildRequires:  autoconf, automake, gtk2-devel, desktop-file-utils
 #Requires:       
@@ -22,6 +24,7 @@ communication mode known as Hellschreiber.
 
 %prep
 %setup -qn %{name}
+%patch0 -p1
 
 
 %build
@@ -49,6 +52,9 @@ desktop-file-install \
 %{_datadir}/applications/%{name}.desktop
 
 %changelog
+* Fri Jun 20 2014 Yaakov Selkowitz <yselkowi at redhat.com> - 1.9-13
+- Fix FTBFS with -Werror=format-security (#1037396, #1107276)
+
 * Sun Jun 08 2014 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.9-12
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
 


More information about the scm-commits mailing list