[firefox] Build fix - make security warnings non-fatal

Martin Stransky stransky at fedoraproject.org
Wed Aug 27 11:45:31 UTC 2014


commit 2b16776365411b15d97f5fbe82005fc67625b9c3
Author: Martin Stransky <stransky at anakreon.cz>
Date:   Wed Aug 27 13:45:32 2014 +0200

    Build fix - make security warnings non-fatal

 firefox.spec |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/firefox.spec b/firefox.spec
index 4750b41..297b385 100644
--- a/firefox.spec
+++ b/firefox.spec
@@ -356,7 +356,9 @@ find ./ -name config.guess -exec cp /usr/lib/rpm/config.guess {} ';'
 #
 MOZ_OPT_FLAGS=$(echo "$RPM_OPT_FLAGS" | %{__sed} -e 's/-Wall//')
 #rhbz#1037063
-MOZ_OPT_FLAGS="$MOZ_OPT_FLAGS -Wformat-security -Wformat -Werror=format-security"
+# -Werror=format-security causes build failures when -Wno-format is explicitly given
+# for some sources
+MOZ_OPT_FLAGS="$MOZ_OPT_FLAGS -Wformat-security -Wformat"
 %if %{?debug_build}
 MOZ_OPT_FLAGS=$(echo "$MOZ_OPT_FLAGS" | %{__sed} -e 's/-O2//')
 %endif


More information about the scm-commits mailing list