[xulrunner] Make -Wformat-security non-fatal

Martin Stransky stransky at fedoraproject.org
Wed Aug 27 11:50:20 UTC 2014


commit 0526f46e39ecd70d58a74eab2217e2cd42cb6109
Author: Martin Stransky <stransky at anakreon.cz>
Date:   Wed Aug 27 13:50:15 2014 +0200

    Make -Wformat-security non-fatal

 xulrunner.spec |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/xulrunner.spec b/xulrunner.spec
index 95804dd..614025f 100644
--- a/xulrunner.spec
+++ b/xulrunner.spec
@@ -346,8 +346,10 @@ MOZ_OPT_FLAGS=$(echo "$MOZ_OPT_FLAGS" | %{__sed} -e 's/-g/-g1/')
 MOZ_LINK_FLAGS="-Wl,--no-keep-memory -Wl,--reduce-memory-overheads"
 %endif
 
-export CFLAGS="$MOZ_OPT_FLAGS -Wformat-security -Wformat -Werror=format-security"
-export CXXFLAGS="$MOZ_OPT_FLAGS -fpermissive -Wformat-security -Wformat -Werror=format-security"
+# -Werror=format-security causes build failures when -Wno-format is explicitly given
+# for some sources
+export CFLAGS="$MOZ_OPT_FLAGS -Wformat-security -Wformat"
+export CXXFLAGS="$MOZ_OPT_FLAGS -fpermissive -Wformat-security -Wformat"
 export LDFLAGS=$MOZ_LINK_FLAGS
 
 export PREFIX='%{_prefix}'


More information about the scm-commits mailing list