[perl-Test-CheckChanges] Specify all dependencies (#1134856)

Paul Howarth pghmcfc at fedoraproject.org
Thu Aug 28 14:00:39 UTC 2014


commit f77875ea2b289c9b3db2ecb9b0c4ad16f3219cbc
Author: Paul Howarth <paul at city-fan.org>
Date:   Thu Aug 28 14:59:59 2014 +0100

    Specify all dependencies (#1134856)
    
    Also drop support for building for EOL-ed EPEL-4

 perl-Test-CheckChanges.spec |   41 +++++++++++++++++++++++++++++++----------
 1 files changed, 31 insertions(+), 10 deletions(-)
---
diff --git a/perl-Test-CheckChanges.spec b/perl-Test-CheckChanges.spec
index f5450bb..6efc4a2 100644
--- a/perl-Test-CheckChanges.spec
+++ b/perl-Test-CheckChanges.spec
@@ -4,24 +4,42 @@
 Name:		perl-Test-CheckChanges
 Summary:	Check that the Changes file matches the distribution
 Version:	0.14
-Release:	10%{?dist}
+Release:	11%{?dist}
 License:	GPL+ or Artistic
 Group:		Development/Libraries
 URL:		http://search.cpan.org/dist/Test-CheckChanges/
 Source0:	http://search.cpan.org/CPAN/authors/id/G/GA/GAM/Test-CheckChanges-%{version}.tar.gz 
 Patch0:		Test-CheckChanges-0.14-old-Test::More.patch
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
-Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 BuildArch:	noarch
+# Module Build
+BuildRequires:	perl
 BuildRequires:	perl(Module::Build)
-BuildRequires:	perl(Test::Exception)
+BuildRequires:	perl(strict)
+BuildRequires:	perl(warnings)
+# Module Runtime
+BuildRequires:	perl(Cwd)
+BuildRequires:	perl(Carp)
+BuildRequires:	perl(File::Basename)
+BuildRequires:	perl(File::Glob)
+BuildRequires:	perl(File::Spec)
+BuildRequires:	perl(Module::Build::Version)
+BuildRequires:	perl(Test::Builder)
+# Test Suite
+BuildRequires:	perl(English)
 BuildRequires:	perl(Test::More)
-# Perl::Critic not available in EPEL-4
-%if "%{?rhel}" != "4"
+# Optional Tests
+BuildRequires:	perl(Test::Exception)
+BuildRequires:	perl(Test::Pod) >= 1.00
+BuildRequires:	perl(Test::Pod::Coverage) >= 1.00
+%if "%{?rhel}" != "5"
+BuildRequires:	perl(Perl::Critic::Policy::NamingConventions::Capitalization)
+BuildRequires:	perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitMagicNumbers)
 BuildRequires:	perl(Test::Perl::Critic)
 %endif
-BuildRequires:	perl(Test::Pod)
-BuildRequires:	perl(Test::Pod::Coverage)
+# Runtime
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires:	perl(Module::Build::Version)
 
 %description
 This module checks that your Changes file has an entry for the current version
@@ -42,12 +60,12 @@ diagnostic messages are printed to help explain the failure.
 %endif
 
 %build
-perl Build.PL installdirs=vendor
+perl Build.PL --installdirs=vendor
 ./Build
 
 %install
 rm -rf %{buildroot}
-./Build install destdir=%{buildroot} create_packlist=0
+./Build install --destdir=%{buildroot} --create_packlist=0
 %{_fixperms} %{buildroot}
 
 %check
@@ -57,12 +75,15 @@ TEST_AUTHOR=1 ./Build test
 rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root,-)
 %doc Changes README examples/
 %{perl_vendorlib}/Test/
 %{_mandir}/man3/Test::CheckChanges.3pm*
 
 %changelog
+* Thu Aug 28 2014 Paul Howarth <paul at city-fan.org> - 0.14-11
+- Specify all dependencies (#1134856)
+- Drop %%defattr, redundant since rpm 4.4
+
 * Sat Jun 07 2014 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.14-10
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
 


More information about the scm-commits mailing list