[evince/f20] Fix a memory leak in find-sidebar

mkasik mkasik at fedoraproject.org
Tue Nov 18 13:58:01 UTC 2014


commit b2576a436b5d6179bf1aaca2d5c2a7be614db643
Author: Marek Kasik <mkasik at redhat.com>
Date:   Tue Nov 18 14:57:48 2014 +0100

    Fix a memory leak in find-sidebar
    
    Resolves: #1147619

 0001-find-sidebar-Fix-memory-leak.patch |   24 ++++++++++++++++++++++++
 evince.spec                             |   10 +++++++++-
 2 files changed, 33 insertions(+), 1 deletions(-)
---
diff --git a/0001-find-sidebar-Fix-memory-leak.patch b/0001-find-sidebar-Fix-memory-leak.patch
new file mode 100644
index 0000000..b3b3fa1
--- /dev/null
+++ b/0001-find-sidebar-Fix-memory-leak.patch
@@ -0,0 +1,24 @@
+From 26e52726991f3eb7dac90470ff88dc000348b1f3 Mon Sep 17 00:00:00 2001
+From: Carlos Garcia Campos <carlosgc at gnome.org>
+Date: Sun, 10 Aug 2014 13:05:56 +0200
+Subject: [PATCH] find-sidebar: Fix memory leak
+
+---
+ shell/ev-find-sidebar.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/shell/ev-find-sidebar.c b/shell/ev-find-sidebar.c
+index 0f7a336..c9882e3 100644
+--- a/shell/ev-find-sidebar.c
++++ b/shell/ev-find-sidebar.c
+@@ -402,6 +402,7 @@ process_matches_idle (EvFindSidebar *sidebar)
+ 
+                 page = ev_document_get_page (document, current_page);
+                 page_text = get_page_text (document, page, &areas, &n_areas);
++                g_object_unref (page);
+                 if (!page_text)
+                         continue;
+ 
+-- 
+2.1.0
+
diff --git a/evince.spec b/evince.spec
index bd6c1f4..c518cae 100644
--- a/evince.spec
+++ b/evince.spec
@@ -5,7 +5,7 @@
 
 Name:           evince
 Version:        3.10.3
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Document viewer
 
 License:        GPLv2+ and GPLv3+ and LGPLv2+ and MIT and Afmparse
@@ -13,6 +13,9 @@ Group:          Applications/Publishing
 URL:            http://projects.gnome.org/evince/
 Source0:        http://download.gnome.org/sources/%{name}/3.10/%{name}-%{version}.tar.xz
 
+# https://bugzilla.redhat.com/show_bug.cgi?id=1147619
+Patch0:         0001-find-sidebar-Fix-memory-leak.patch
+
 BuildRequires:  gtk3-devel
 BuildRequires:  glib2-devel >= %{glib2_version}
 BuildRequires:  poppler-glib-devel >= %{poppler_version}
@@ -106,6 +109,7 @@ It adds an additional tab called "Document" to the file properties dialog.
 
 %prep
 %setup -q
+%patch0 -p1 -b .search-leak
 
 %build
 ./autogen.sh
@@ -216,6 +220,10 @@ glib-compile-schemas %{_datadir}/glib-2.0/schemas >&/dev/null ||:
 %{_libdir}/nautilus/extensions-3.0/libevince-properties-page.so
 
 %changelog
+* Tue Nov 18 2014 Marek Kasik <mkasik at redhat.com> - 3.10.3-2
+- Fix a memory leak in find-sidebar
+- Resolves: #1147619
+
 * Mon Nov 18 2013 Marek Kasik <mkasik at redhat.com> - 3.10.3-1
 - Update to 3.10.3
 


More information about the scm-commits mailing list