[xscreensaver] Enable double buffer on noof (Ubuntu bug 1390304)

Mamoru TASAKA mtasaka at fedoraproject.org
Fri Dec 19 18:09:39 UTC 2014


commit 5d23e4487a1b5bf6accf246a779706adb6036bdf
Author: Mamoru TASAKA <mtasaka at fedoraproject.org>
Date:   Sat Dec 20 03:09:28 2014 +0900

    Enable double buffer on noof (Ubuntu bug 1390304)

 ...2-0001-noof-enable-double-buffer-on-linux.patch |   39 ++++++++++++++++++++
 xscreensaver.spec                                  |   10 +++++-
 2 files changed, 48 insertions(+), 1 deletions(-)
---
diff --git a/xscreensaver-5.32-0001-noof-enable-double-buffer-on-linux.patch b/xscreensaver-5.32-0001-noof-enable-double-buffer-on-linux.patch
new file mode 100644
index 0000000..e965b9c
--- /dev/null
+++ b/xscreensaver-5.32-0001-noof-enable-double-buffer-on-linux.patch
@@ -0,0 +1,39 @@
+From 5a9cd418ca6c6841f89078c6d8eda880d170fbd4 Mon Sep 17 00:00:00 2001
+From: Mamoru TASAKA <mtasaka at fedoraproject.org>
+Date: Sat, 20 Dec 2014 01:57:28 +0900
+Subject: [PATCH] noof: enable double buffer on linux
+
+It seems that at least on Fedora 21 x86_64 box,
+while noof can be displayed on xscreensaver-demo
+window it shows whole black screen in actual
+saver mode, as written on launchpad #1390304.
+
+It seems that enabling double buffer resolves
+this issue. As other gl hacks also uses double
+buffer and there seems no problem, just enable
+double buffer also on linux.
+
+Maybe it is better that double buffering gets
+enabled by default but disabled on the specified
+platform.
+---
+ hacks/glx/noof.c | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/hacks/glx/noof.c b/hacks/glx/noof.c
+index ee2810b..2dc4f78 100644
+--- a/hacks/glx/noof.c
++++ b/hacks/glx/noof.c
+@@ -448,6 +448,9 @@ init_noof (ModeInfo *mi)
+ #ifdef HAVE_JWZGLES
+   dbuf_p = 1;
+ #endif
++#ifdef __linux__
++  dbuf_p = 1;
++#endif
+ 
+   if (!bps) {
+     bps = (noof_configuration *)
+-- 
+2.1.0
+
diff --git a/xscreensaver.spec b/xscreensaver.spec
index d411488..ae5f996 100644
--- a/xscreensaver.spec
+++ b/xscreensaver.spec
@@ -10,7 +10,7 @@
 %define split_getimage   1
 %endif
 
-%define fedora_rel    2
+%define fedora_rel    3
 
 %global use_clang_as_cc 0
 %global use_clang_analyze 0
@@ -80,6 +80,9 @@ Patch52:         xscreensaver-5.12-tests-miscfix.patch
 # 
 # gcc49 sanitizer fix
 #
+# Enable double buffer on noof (Ubuntu bug 1390304)
+Patch201:        xscreensaver-5.32-0001-noof-enable-double-buffer-on-linux.patch
+#
 # Patches end
 Requires:        xscreensaver-base = %{epoch}:%{version}-%{release}
 Requires:        xscreensaver-extras = %{epoch}:%{version}-%{release}
@@ -332,6 +335,8 @@ rm -f driver/XScreenSaver_ad.h
 %patch52 -p1
   %__git commit -m "%PATCH52_desc" -a
 
+%__cat %PATCH201 | %__git am
+
 change_option(){
    set +x
    ADFILE=$1
@@ -978,6 +983,9 @@ exit 0
 %endif
 
 %changelog
+* Sat Dec 20 2014 Mamoru TASAKA <mtasaka at fedoraproject.org> - 1:5.32-3
+- Enable double buffer on noof (Ubuntu bug 1390304)
+
 * Sun Dec  7 2014 Mamoru TASAKA <mtasaka at fedoraproject.org> - 1:5.32-2
 - Patch from upstream for some GNOME issues with KeyPress
 


More information about the scm-commits mailing list