[libreoffice/f21] Resolves: rhbz#1184582 crash in grammar checking thread
sbergmann
sbergmann at fedoraproject.org
Thu Jan 22 12:20:36 UTC 2015
commit 9dff0081238c793c00dc166935f81532e770c3d2
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Thu Jan 22 13:20:54 2015 +0100
Resolves: rhbz#1184582 crash in grammar checking thread
...2-At-least-catch-and-log-UNO-exceptions-i.patch | 153 ++++++++++++++++++++
libreoffice.spec | 2 +
2 files changed, 155 insertions(+), 0 deletions(-)
---
diff --git a/0001-rhbz-1184582-At-least-catch-and-log-UNO-exceptions-i.patch b/0001-rhbz-1184582-At-least-catch-and-log-UNO-exceptions-i.patch
new file mode 100644
index 0000000..433b9e2
--- /dev/null
+++ b/0001-rhbz-1184582-At-least-catch-and-log-UNO-exceptions-i.patch
@@ -0,0 +1,153 @@
+From d7548760e51941dad67389b21e943a968b37ba7c Mon Sep 17 00:00:00 2001
+From: Stephan Bergmann <sbergman at redhat.com>
+Date: Thu, 22 Jan 2015 12:47:29 +0100
+Subject: [PATCH] rhbz#1184582: At least catch and log UNO exceptions in
+ grammar checking thread
+
+(cherry picked from commit b1dbc511eeaf88e3b4b5a8a2dce129d251d2dcb6)
+Conflicts:
+ linguistic/source/gciterator.cxx
+
+Change-Id: I87744f86d1413973709a46a58ebc03a39bce842c
+---
+ linguistic/source/gciterator.cxx | 110 +++++++++++++++++++++------------------
+ 1 file changed, 60 insertions(+), 50 deletions(-)
+
+diff --git a/linguistic/source/gciterator.cxx b/linguistic/source/gciterator.cxx
+index 74f9aba..35c8875 100644
+--- a/linguistic/source/gciterator.cxx
++++ b/linguistic/source/gciterator.cxx
+@@ -543,70 +543,80 @@ void GrammarCheckingIterator::DequeueAndCheck()
+
+ if (xFlatPara.is() && xFPIterator.is())
+ {
+- OUString aCurTxt( xFlatPara->getText() );
+- lang::Locale aCurLocale = lcl_GetPrimaryLanguageOfSentence( xFlatPara, aFPEntryItem.m_nStartIndex );
+-
+- bModified = xFlatPara->isModified();
+- if (!bModified)
++ try
+ {
+- // ---- THREAD SAFE START ----
+- ::osl::ClearableGuard< ::osl::Mutex > aGuard( MyMutex::get() );
++ OUString aCurTxt( xFlatPara->getText() );
++ lang::Locale aCurLocale = lcl_GetPrimaryLanguageOfSentence( xFlatPara, aFPEntryItem.m_nStartIndex );
+
+- sal_Int32 nStartPos = aFPEntryItem.m_nStartIndex;
+- sal_Int32 nSuggestedEnd = GetSuggestedEndOfSentence( aCurTxt, nStartPos, aCurLocale );
+- DBG_ASSERT( (nSuggestedEnd == 0 && aCurTxt.isEmpty()) || nSuggestedEnd > nStartPos,
+- "nSuggestedEndOfSentencePos calculation failed?" );
++ bModified = xFlatPara->isModified();
++ if (!bModified)
++ {
++ // ---- THREAD SAFE START ----
++ ::osl::ClearableGuard< ::osl::Mutex > aGuard( MyMutex::get() );
+
+- linguistic2::ProofreadingResult aRes;
++ sal_Int32 nStartPos = aFPEntryItem.m_nStartIndex;
++ sal_Int32 nSuggestedEnd = GetSuggestedEndOfSentence( aCurTxt, nStartPos, aCurLocale );
++ DBG_ASSERT( (nSuggestedEnd == 0 && aCurTxt.isEmpty()) || nSuggestedEnd > nStartPos,
++ "nSuggestedEndOfSentencePos calculation failed?" );
+
+- uno::Reference< linguistic2::XProofreader > xGC( GetGrammarChecker( aCurLocale ), uno::UNO_QUERY );
+- if (xGC.is())
+- {
+- aGuard.clear();
+- uno::Sequence<beans::PropertyValue> const aProps(
++ linguistic2::ProofreadingResult aRes;
++
++ uno::Reference< linguistic2::XProofreader > xGC( GetGrammarChecker( aCurLocale ), uno::UNO_QUERY );
++ if (xGC.is())
++ {
++ aGuard.clear();
++ uno::Sequence<beans::PropertyValue> const aProps(
+ lcl_makeProperties(xFlatPara));
+- aRes = xGC->doProofreading( aCurDocId, aCurTxt,
+- aCurLocale, nStartPos, nSuggestedEnd, aProps );
+-
+- //!! work-around to prevent looping if the grammar checker
+- //!! failed to properly identify the sentence end
+- if (
+- aRes.nBehindEndOfSentencePosition <= nStartPos &&
+- aRes.nBehindEndOfSentencePosition != nSuggestedEnd
+- )
++ aRes = xGC->doProofreading( aCurDocId, aCurTxt,
++ aCurLocale, nStartPos, nSuggestedEnd, aProps );
++
++ //!! work-around to prevent looping if the grammar checker
++ //!! failed to properly identify the sentence end
++ if (
++ aRes.nBehindEndOfSentencePosition <= nStartPos &&
++ aRes.nBehindEndOfSentencePosition != nSuggestedEnd
++ )
++ {
++ DBG_ASSERT( false, "!! Grammarchecker failed to provide end of sentence !!" );
++ aRes.nBehindEndOfSentencePosition = nSuggestedEnd;
++ }
++
++ aRes.xFlatParagraph = xFlatPara;
++ aRes.nStartOfSentencePosition = nStartPos;
++ }
++ else
+ {
+- DBG_ASSERT( false, "!! Grammarchecker failed to provide end of sentence !!" );
+- aRes.nBehindEndOfSentencePosition = nSuggestedEnd;
++ // no grammar checker -> no error
++ // but we need to provide the data below in order to continue with the next sentence
++ aRes.aDocumentIdentifier = aCurDocId;
++ aRes.xFlatParagraph = xFlatPara;
++ aRes.aText = aCurTxt;
++ aRes.aLocale = aCurLocale;
++ aRes.nStartOfSentencePosition = nStartPos;
++ aRes.nBehindEndOfSentencePosition = nSuggestedEnd;
+ }
++ aRes.nStartOfNextSentencePosition = lcl_SkipWhiteSpaces( aCurTxt, aRes.nBehindEndOfSentencePosition );
++ aRes.nBehindEndOfSentencePosition = lcl_BacktraceWhiteSpaces( aCurTxt, aRes.nStartOfNextSentencePosition );
+
+- aRes.xFlatParagraph = xFlatPara;
+- aRes.nStartOfSentencePosition = nStartPos;
++ //guard has to be cleared as ProcessResult calls out of this class
++ aGuard.clear();
++ ProcessResult( aRes, xFPIterator, aFPEntryItem.m_bAutomatic );
++ // ---- THREAD SAFE END ----
+ }
+ else
+ {
+- // no grammar checker -> no error
+- // but we need to provide the data below in order to continue with the next sentence
+- aRes.aDocumentIdentifier = aCurDocId;
+- aRes.xFlatParagraph = xFlatPara;
+- aRes.aText = aCurTxt;
+- aRes.aLocale = aCurLocale;
+- aRes.nStartOfSentencePosition = nStartPos;
+- aRes.nBehindEndOfSentencePosition = nSuggestedEnd;
++ // the paragraph changed meanwhile... (and maybe is still edited)
++ // thus we simply continue to ask for the next to be checked.
++ uno::Reference< text::XFlatParagraph > xFlatParaNext( xFPIterator->getNextPara() );
++ AddEntry( xFPIterator, xFlatParaNext, aCurDocId, 0, aFPEntryItem.m_bAutomatic );
+ }
+- aRes.nStartOfNextSentencePosition = lcl_SkipWhiteSpaces( aCurTxt, aRes.nBehindEndOfSentencePosition );
+- aRes.nBehindEndOfSentencePosition = lcl_BacktraceWhiteSpaces( aCurTxt, aRes.nStartOfNextSentencePosition );
+-
+- //guard has to be cleared as ProcessResult calls out of this class
+- aGuard.clear();
+- ProcessResult( aRes, xFPIterator, aFPEntryItem.m_bAutomatic );
+- // ---- THREAD SAFE END ----
+ }
+- else
++ catch (css::uno::Exception & e)
+ {
+- // the paragraph changed meanwhile... (and maybe is still edited)
+- // thus we simply continue to ask for the next to be checked.
+- uno::Reference< text::XFlatParagraph > xFlatParaNext( xFPIterator->getNextPara() );
+- AddEntry( xFPIterator, xFlatParaNext, aCurDocId, 0, aFPEntryItem.m_bAutomatic );
++ SAL_WARN(
++ "linguistic",
++ "GrammarCheckingIterator::DequeueAndCheck ignoring UNO"
++ " exception " << e.Message);
+ }
+ }
+
+--
+1.9.3
+
diff --git a/libreoffice.spec b/libreoffice.spec
index cd4c066..a5117e9 100644
--- a/libreoffice.spec
+++ b/libreoffice.spec
@@ -371,6 +371,7 @@ Patch63: 0001-Resolves-rhbz-1162352-SwDataChanged-dtor-accesses-de.patch
Patch64: 0001-Resolves-fdo-86978-append-formula-cells-to-track-ins.patch
Patch65: 0001-if-we-change-the-keys-we-have-to-resort-based-on-the.patch
Patch66: 0001-font-cache-gets-broken-on-adding-an-embedded-font.patch
+Patch67: 0001-rhbz-1184582-At-least-catch-and-log-UNO-exceptions-i.patch
%define instdir %{_libdir}
%define baseinstdir %{instdir}/libreoffice
@@ -2346,6 +2347,7 @@ update-desktop-database %{_datadir}/applications &> /dev/null || :
- Resolves: rhbz#1136013 ExternalToolEdit crash
- font cache gets broken on adding an embedded font
- if we change the keys we have to resort based on the new keys
+- Resolves: rhbz#1184582 crash in grammar checking thread
* Fri Jan 16 2015 Eike Rathke <erack at redhat.com> - 1:4.3.5.2-11
- Resolves: rhbz#1171828 fdo#86978 append formula cells to track instead of tree
More information about the scm-commits
mailing list