rhughes pushed to ibus-anthy (master). "Add the AppData file to the right built RPM"

notifications at fedoraproject.org notifications at fedoraproject.org
Thu Mar 26 09:42:51 UTC 2015


>From 69cf7a7e57f08017e84c07b7e6add247f970d5c2 Mon Sep 17 00:00:00 2001
From: Richard Hughes <richard at hughsie.com>
Date: Thu, 26 Mar 2015 09:32:44 +0000
Subject: Add the AppData file to the right built RPM


diff --git a/ibus-anthy.spec b/ibus-anthy.spec
index 803586b..f7ff363 100644
--- a/ibus-anthy.spec
+++ b/ibus-anthy.spec
@@ -129,7 +129,13 @@ make %{?_smp_mflags}
 make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
 rm -f $RPM_BUILD_ROOT%{_libdir}/libanthygobject-%{sub_version}.la
 
-# register as an AppStream component
+# Register as an AppStream component to be visible in the software center
+#
+# NOTE: It would be *awesome* if this file was maintained by the upstream
+# project, translated and installed into the right place during `make install`.
+#
+# See http://www.freedesktop.org/software/appstream/docs/ for more details.
+#
 mkdir -p $RPM_BUILD_ROOT%{_datadir}/appdata
 cat > $RPM_BUILD_ROOT%{_datadir}/appdata/anthy.appdata.xml <<EOF
 <?xml version="1.0" encoding="UTF-8"?>
@@ -193,12 +199,12 @@ touch --no-create %{_datadir}/icons/hicolor || :
 %{_datadir}/ibus-anthy
 %{_datadir}/ibus/component/*
 %endif
-%{_datadir}/appdata/*.appdata.xml
 %{_datadir}/icons/hicolor/scalable/apps/ibus-anthy.svg 
 
 %if %with_python_pkg
 %files python
 %{_libexecdir}/ibus-*-anthy
+%{_datadir}/appdata/*.appdata.xml
 %{_datadir}/applications/ibus-setup-anthy.desktop
 %{_datadir}/ibus-anthy/engine
 %{_datadir}/ibus-anthy/setup
@@ -211,6 +217,12 @@ touch --no-create %{_datadir}/icons/hicolor || :
 %{_libdir}/libanthygobject-%{sub_version}.so
 
 %changelog
+* Wed Mar 25 2015 Richard Hughes <rhughes at redhat.com> - 1.5.6-5
+- Add the AppData file to the right built RPM, in this case we have to install
+  ibus-anthy-python rather than the main package in gnome-software.
+- It turns out adding the AppData file to spec files is a great way to fix these
+  kinds of bugs. :)
+
 * Wed Mar 25 2015 Richard Hughes <rhughes at redhat.com> - 1.5.6-4
 - Use an AppStream file compatible with F22 also.
 
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/ibus-anthy.git/commit/?h=master&id=69cf7a7e57f08017e84c07b7e6add247f970d5c2


More information about the scm-commits mailing list