pghmcfc pushed to perl-Email-Reply (master). "Rationalize buildreqs, modernize spec (..more)"

notifications at fedoraproject.org notifications at fedoraproject.org
Tue Mar 31 06:56:32 UTC 2015


>From d39812b36e49a9ef11202d9a926b0a18c447fc8c Mon Sep 17 00:00:00 2001
From: Paul Howarth <paul at city-fan.org>
Date: Tue, 24 Mar 2015 09:24:06 +0000
Subject: Rationalize buildreqs, modernize spec

- Classify buildreqs by usage
- Use %license where possible
- Don't need to remove empty directories from the buildroot
- Drop %defattr, redundant since rpm 4.4
- Don't use macros for commands
- Make %files list more explicit

diff --git a/perl-Email-Reply.spec b/perl-Email-Reply.spec
index 142ef41..3af7ba0 100644
--- a/perl-Email-Reply.spec
+++ b/perl-Email-Reply.spec
@@ -1,18 +1,30 @@
 Name:           perl-Email-Reply
 Version:        1.203
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Reply to an email message
 Group:          Development/Libraries
 License:        GPL+ or Artistic
 URL:            http://search.cpan.org/dist/Email-Reply/
 Source0:        http://search.cpan.org/CPAN/authors/id/R/RJ/RJBS/Email-Reply-%{version}.tar.gz
-BuildRequires:  perl(ExtUtils::MakeMaker), perl(Email::Abstract), perl(Email::Address)
-BuildRequires:  perl(Email::MIME), perl(Test::More), perl(Email::MIME::Creator)
-BuildRequires:  perl(Email::MIME::Modifier), perl(Test::Pod), perl(Test::Pod::Coverage)
-BuildRequires:  perl(Email::Simple), perl(Email::Simple::Creator), perl(Email::Date)
-BuildRequires:  perl(Module::Pluggable), perl(Capture::Tiny)
 BuildArch:      noarch
-Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+# Module Build
+BuildRequires:  perl
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.30
+# Module Runtime
+BuildRequires:  perl(Email::Abstract) >= 2.01
+BuildRequires:  perl(Email::Address) >= 1.80
+BuildRequires:  perl(Email::MIME) >= 1.82
+BuildRequires:  perl(Exporter) >= 5.57
+BuildRequires:  perl(strict)
+BuildRequires:  perl(warnings)
+# Test Suite
+BuildRequires:  perl(Capture::Tiny)
+BuildRequires:  perl(Email::MIME::Modifier)
+BuildRequires:  perl(Email::Simple)
+BuildRequires:  perl(Email::Simple::Creator)
+BuildRequires:  perl(Test::More) >= 0.88
+# Runtime
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 This package provides a simple way to reply to email messages.
@@ -21,26 +33,36 @@ This package provides a simple way to reply to email messages.
 %setup -q -n Email-Reply-%{version}
 
 %build
-sed -i '/LICENSE/ d' Makefile.PL
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make
 
 %install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+%{_fixperms} %{buildroot}
 
 %check
 make test
 
 %files
-%defattr(-,root,root,-)
-%doc README LICENSE
+%if 0%{?_licensedir:1}
+%license LICENSE
+%else
+%doc LICENSE
+%endif
+%doc README
 %{perl_vendorlib}/Email/
-%{_mandir}/man3/*.3*
+%{_mandir}/man3/Email::Reply.3*
 
 %changelog
+* Tue Mar 24 2015 Paul Howarth <paul at city-fan.org> - 1.203-2
+- Classify buildreqs by usage
+- Use %%license where possible
+- Don't need to remove empty directories from the buildroot
+- Drop %%defattr, redundant since rpm 4.4
+- Don't use macros for commands
+- Make %%files list more explicit
+
 * Fri Mar 20 2015 Tom Callaway <spot at fedoraproject.org> - 1.203-1
 - update to 1.203
 
@@ -79,7 +101,7 @@ make test
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Thu Dec 16 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.202-8
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Sat May 01 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.202-7
 - Mass rebuild with perl-5.12.0
@@ -97,7 +119,7 @@ make test
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
 * Thu Mar 06 2008 Tom "spot" Callaway <tcallawa at redhat.com> - 1.202-2
-Rebuild for new perl
+- Rebuild for new perl
 
 * Sun Aug 26 2007 Tom "spot" Callaway <tcallawa at redhat.com> - 1.201-4
 - 1.202
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/perl-Email-Reply.git/commit/?h=master&id=d39812b36e49a9ef11202d9a926b0a18c447fc8c


More information about the scm-commits mailing list