jreznik pushed to arts (epel7). "unify KDE 3 autotools fixes between packages (..more)"
notifications at fedoraproject.org
notifications at fedoraproject.org
Thu Apr 2 15:12:51 UTC 2015
>From 1945dafc038c1fa70db6155a76dd18b27e9482b0 Mon Sep 17 00:00:00 2001
From: Kevin Kofler <Kevin at tigcc.ticalc.org>
Date: Sat, 9 Mar 2013 01:28:07 +0100
Subject: unify KDE 3 autotools fixes between packages
* Sat Mar 09 2013 Kevin Kofler <Kevin at tigcc.ticalc.org> - 1.5.10-21
- unify KDE 3 autotools fixes between packages
diff --git a/arts-1.5.10-automake-1.13.patch b/arts-1.5.10-automake-1.13.patch
deleted file mode 100644
index 45269bf..0000000
--- a/arts-1.5.10-automake-1.13.patch
+++ /dev/null
@@ -1,12 +0,0 @@
-diff -up arts-1.5.10/admin/cvs.sh.me arts-1.5.10/admin/cvs.sh
---- arts-1.5.10/admin/cvs.sh.me 2013-03-07 18:08:31.003844848 +0100
-+++ arts-1.5.10/admin/cvs.sh 2013-03-07 18:09:07.187488301 +0100
-@@ -130,7 +130,7 @@ if egrep "^AM_CONFIG_HEADER" configure.i
- fi
-
- echo "*** Creating Makefile templates"
--$AUTOMAKE || exit 1
-+$AUTOMAKE --add-missing || exit 1
-
- if test "$UNSERMAKE" = no; then
- echo "*** Postprocessing Makefile templates"
diff --git a/arts-1.5.10-automake.patch b/arts-1.5.10-automake.patch
deleted file mode 100644
index 756d5f6..0000000
--- a/arts-1.5.10-automake.patch
+++ /dev/null
@@ -1,17 +0,0 @@
-diff -up arts-1.5.10/admin/cvs.sh.automake arts-1.5.10/admin/cvs.sh
---- arts-1.5.10/admin/cvs.sh.automake 2008-08-19 22:18:41.000000000 +0200
-+++ arts-1.5.10/admin/cvs.sh 2012-07-04 12:33:15.747586088 +0200
-@@ -63,12 +63,7 @@ esac
- AUTOMAKE_STRING=`$AUTOMAKE --version | head -n 1`
- required_automake_version="1.6.1 or newer"
- case $AUTOMAKE_STRING in
-- automake*1.5d* | automake*1.5* | automake*1.5-* )
-- echo "*** YOU'RE USING $AUTOMAKE_STRING."
-- echo "*** KDE requires automake $required_automake_version"
-- exit 1
-- ;;
-- automake*1.6.* | automake*1.7* | automake*1.8* | automake*1.9* | automake*1.10*)
-+ automake*1.6.* | automake*1.7* | automake*1.8* | automake*1.9* | automake*1.1[0-5]*)
- echo "*** $AUTOMAKE_STRING found."
- UNSERMAKE=no
- ;;
diff --git a/arts-acinclude.patch b/arts-acinclude.patch
deleted file mode 100644
index 0610d6d..0000000
--- a/arts-acinclude.patch
+++ /dev/null
@@ -1,66 +0,0 @@
-2009-12-10 Stepan Kasal <skasal at redhat.com>
-
-The change of implementation of AC_REQUIRE in 2.64 caused a regression
-in the arts project.
-This can be fixed by shuffling some macro calls.
-
-I suppose that most of this patch will not be needed with a future
-release of Autoconf.
-But the last chunk of this patch is a real bug in this source and
-should go upstream.
-
---- arts-1.5.10/admin/acinclude.m4.in 2008-08-20 18:07:05.000000000 +0200
-+++ arts-1.5.10/admin/acinclude.m4.in 2009-12-09 17:30:57.000000000 +0100
-@@ -3081,8 +3081,18 @@
- fi
- ])
-
-+AC_DEFUN([AC_CHECK_COMPILERS_CC],
-+[
-+ dnl this prevents stupid AC_PROG_CC to add "-g" to the default CFLAGS
-+ CFLAGS=" $CFLAGS"
-+ AC_PROG_CC
-+ CXXFLAGS=" $CXXFLAGS"
-+ AC_PROG_CXX
-+])
-+
- AC_DEFUN([AC_CHECK_COMPILERS],
- [
-+ AC_REQUIRE([AC_CHECK_COMPILERS_CC])
- AC_ARG_ENABLE(debug,
- AC_HELP_STRING([--enable-debug=ARG],[enables debug symbols (yes|no|full) [default=no]]),
- [
-@@ -3141,11 +3151,6 @@
- [kde_use_profiling="no"]
- )
-
-- dnl this prevents stupid AC_PROG_CC to add "-g" to the default CFLAGS
-- CFLAGS=" $CFLAGS"
--
-- AC_PROG_CC
--
- AC_PROG_CPP
-
- if test "$GCC" = "yes"; then
-@@ -3174,10 +3179,6 @@
- LDFLAGS=""
- fi
-
-- CXXFLAGS=" $CXXFLAGS"
--
-- AC_PROG_CXX
--
- KDE_CHECK_FOR_BAD_COMPILER
-
- if test "$GXX" = "yes" || test "$CXX" = "KCC"; then
-@@ -3503,8 +3504,8 @@
- AC_REQUIRE([AC_LIBTOOL_DLOPEN])
- AC_REQUIRE([KDE_CHECK_LIB64])
-
--AC_OBJEXT
--AC_EXEEXT
-+AC_REQUIRE([AC_OBJEXT])
-+AC_REQUIRE([AC_EXEEXT])
-
- AM_PROG_LIBTOOL
- AC_LIBTOOL_CXX
diff --git a/arts.spec b/arts.spec
index 7e331dd..b3491ad 100644
--- a/arts.spec
+++ b/arts.spec
@@ -3,14 +3,12 @@
%define multilib_arches %{ix86} x86_64 ppc ppc64 s390 s390x sparcv9 sparc64
-%define make_cvs 1
-
Name: arts
Summary: aRts (analog realtime synthesizer) - the KDE sound system
Group: System Environment/Daemons
Epoch: 8
Version: 1.5.10
-Release: 20%{?dist}
+Release: 21%{?dist}
License: LGPLv2+
Url: http://www.kde.org
@@ -31,9 +29,6 @@ Patch10: arts-1.5.10-assertion-failure.patch
# kde#93359
Patch50: arts-1.5.4-dlopenext.patch
Patch51: kde-3.5-libtool-shlibext.patch
-# fix build failture with automake-1.13
-patch52: arts-1.5.10-automake-1.13.patch
-
# upstream patches
@@ -41,10 +36,13 @@ patch52: arts-1.5.10-automake-1.13.patch
# CVE-2009-3736 libtool: libltdl may load and execute code from a library in the current directory
Patch200: libltdl-CVE-2009-3736.patch
+# fixes to common KDE 3 autotools machinery
# tweak autoconfigury so that it builds with autoconf 2.64 or 2.65
-Patch300: arts-acinclude.patch
-# update for recent automake
-Patch301: arts-1.5.10-automake.patch
+Patch300: kde3-acinclude.patch
+# remove flawed and obsolete automake version check in admin/cvs.sh
+Patch301: kde3-automake-version.patch
+# fix build failure with automake 1.13: add the --add-missing flag
+Patch302: arts-1.5.10-automake-1.13.patch
# used in artsdsp
Requires: which
@@ -52,9 +50,7 @@ Requires: which
BuildRequires: qt3-devel >= 3.3.8
BuildRequires: alsa-lib-devel
BuildRequires: audiofile-devel
-%if %{make_cvs}
BuildRequires: automake libtool
-%endif
BuildRequires: findutils sed
BuildRequires: glib2-devel
BuildRequires: libvorbis-devel
@@ -102,14 +98,11 @@ Install %{name}-devel if you intend to write applications using aRts.
%patch200 -p1 -b .CVE-2009-3736
%patch300 -p1 -b .acinclude
-%patch301 -p1 -b .automake
+%patch301 -p1 -b .automake-version
+%patch302 -p1 -b .automake-add-missing
%build
-
-%if %{make_cvs}
- make -f admin/Makefile.common cvs
-%endif
-
+make -f admin/Makefile.common cvs
unset QTDIR && . /etc/profile.d/qt.sh
@@ -205,6 +198,9 @@ rm -rf %{buildroot}
%changelog
+* Sat Mar 09 2013 Kevin Kofler <Kevin at tigcc.ticalc.org> - 1.5.10-21
+- unify KDE 3 autotools fixes between packages
+
* Thu Mar 07 2013 Than Ngo <than at redhat.com> - 1.5.10-20
- fix FTBFS in rawhide
diff --git a/kde3-acinclude.patch b/kde3-acinclude.patch
new file mode 100644
index 0000000..0610d6d
--- /dev/null
+++ b/kde3-acinclude.patch
@@ -0,0 +1,66 @@
+2009-12-10 Stepan Kasal <skasal at redhat.com>
+
+The change of implementation of AC_REQUIRE in 2.64 caused a regression
+in the arts project.
+This can be fixed by shuffling some macro calls.
+
+I suppose that most of this patch will not be needed with a future
+release of Autoconf.
+But the last chunk of this patch is a real bug in this source and
+should go upstream.
+
+--- arts-1.5.10/admin/acinclude.m4.in 2008-08-20 18:07:05.000000000 +0200
++++ arts-1.5.10/admin/acinclude.m4.in 2009-12-09 17:30:57.000000000 +0100
+@@ -3081,8 +3081,18 @@
+ fi
+ ])
+
++AC_DEFUN([AC_CHECK_COMPILERS_CC],
++[
++ dnl this prevents stupid AC_PROG_CC to add "-g" to the default CFLAGS
++ CFLAGS=" $CFLAGS"
++ AC_PROG_CC
++ CXXFLAGS=" $CXXFLAGS"
++ AC_PROG_CXX
++])
++
+ AC_DEFUN([AC_CHECK_COMPILERS],
+ [
++ AC_REQUIRE([AC_CHECK_COMPILERS_CC])
+ AC_ARG_ENABLE(debug,
+ AC_HELP_STRING([--enable-debug=ARG],[enables debug symbols (yes|no|full) [default=no]]),
+ [
+@@ -3141,11 +3151,6 @@
+ [kde_use_profiling="no"]
+ )
+
+- dnl this prevents stupid AC_PROG_CC to add "-g" to the default CFLAGS
+- CFLAGS=" $CFLAGS"
+-
+- AC_PROG_CC
+-
+ AC_PROG_CPP
+
+ if test "$GCC" = "yes"; then
+@@ -3174,10 +3179,6 @@
+ LDFLAGS=""
+ fi
+
+- CXXFLAGS=" $CXXFLAGS"
+-
+- AC_PROG_CXX
+-
+ KDE_CHECK_FOR_BAD_COMPILER
+
+ if test "$GXX" = "yes" || test "$CXX" = "KCC"; then
+@@ -3503,8 +3504,8 @@
+ AC_REQUIRE([AC_LIBTOOL_DLOPEN])
+ AC_REQUIRE([KDE_CHECK_LIB64])
+
+-AC_OBJEXT
+-AC_EXEEXT
++AC_REQUIRE([AC_OBJEXT])
++AC_REQUIRE([AC_EXEEXT])
+
+ AM_PROG_LIBTOOL
+ AC_LIBTOOL_CXX
diff --git a/kde3-automake-add-missing.patch b/kde3-automake-add-missing.patch
new file mode 100644
index 0000000..9792f70
--- /dev/null
+++ b/kde3-automake-add-missing.patch
@@ -0,0 +1,12 @@
+diff -up kdelibs-3.5.10/admin/cvs.sh.me kdelibs-3.5.10/admin/cvs.sh
+--- kdelibs-3.5.10/admin/cvs.sh.me 2013-03-07 18:31:59.415038395 +0100
++++ kdelibs-3.5.10/admin/cvs.sh 2013-03-07 18:32:26.565020369 +0100
+@@ -130,7 +130,7 @@ if egrep "^AM_CONFIG_HEADER" configure.i
+ fi
+
+ echo "*** Creating Makefile templates"
+-$AUTOMAKE || exit 1
++$AUTOMAKE --add-missing || exit 1
+
+ if test "$UNSERMAKE" = no; then
+ echo "*** Postprocessing Makefile templates"
diff --git a/kde3-automake-version.patch b/kde3-automake-version.patch
new file mode 100644
index 0000000..6ee4e6d
--- /dev/null
+++ b/kde3-automake-version.patch
@@ -0,0 +1,17 @@
+diff -ur kdelibs-3.5.10/admin/cvs.sh kdelibs-3.5.10-automake-version/admin/cvs.sh
+--- kdelibs-3.5.10/admin/cvs.sh 2008-08-19 22:28:39.000000000 +0200
++++ kdelibs-3.5.10-automake-version/admin/cvs.sh 2012-06-12 01:24:13.000000000 +0200
+@@ -63,12 +63,7 @@
+ AUTOMAKE_STRING=`$AUTOMAKE --version | head -n 1`
+ required_automake_version="1.6.1 or newer"
+ case $AUTOMAKE_STRING in
+- automake*1.5d* | automake*1.5* | automake*1.5-* )
+- echo "*** YOU'RE USING $AUTOMAKE_STRING."
+- echo "*** KDE requires automake $required_automake_version"
+- exit 1
+- ;;
+- automake*1.6.* | automake*1.7* | automake*1.8* | automake*1.9* | automake*1.10*)
++ automake*)
+ echo "*** $AUTOMAKE_STRING found."
+ UNSERMAKE=no
+ ;;
--
cgit v0.10.2
http://pkgs.fedoraproject.org/cgit/arts.git/commit/?h=epel7&id=1945dafc038c1fa70db6155a76dd18b27e9482b0
More information about the scm-commits
mailing list