hrw pushed to honeyd (master). "fix syslog() calls so -format-security works"

notifications at fedoraproject.org notifications at fedoraproject.org
Thu Apr 9 10:28:22 UTC 2015


>From dad79908a0309c058007572b2bd5c51c37430377 Mon Sep 17 00:00:00 2001
From: Marcin Juszkiewicz <mjuszkiewicz at redhat.com>
Date: Fri, 3 Oct 2014 12:16:44 +0200
Subject: fix syslog() calls so -format-security works


diff --git a/honeyd-format-security.patch b/honeyd-format-security.patch
new file mode 100644
index 0000000..567afd2
--- /dev/null
+++ b/honeyd-format-security.patch
@@ -0,0 +1,25 @@
+Index: honeyd-1.5c/command.c
+===================================================================
+--- honeyd-1.5c.orig/command.c
++++ honeyd-1.5c/command.c
+@@ -320,7 +320,7 @@ cmd_droppriv(uid_t uid, gid_t gid)
+ 
+ 	return;
+  error:
+-	syslog(LOG_WARNING, error);
++	syslog(LOG_WARNING, "%s", error);
+ 	errx(1, "%s: terminated", __func__);
+ }
+ 
+Index: honeyd-1.5c/hsniff.c
+===================================================================
+--- honeyd-1.5c.orig/hsniff.c
++++ honeyd-1.5c/hsniff.c
+@@ -809,6 +809,6 @@ droppriv(uid_t uid, gid_t gid)
+ 
+ 	return;
+  error:
+-	syslog(LOG_WARNING, error);
++	syslog(LOG_WARNING, "%s", error);
+ 	errx(1, "%s: terminated", __func__);
+ }
diff --git a/honeyd.spec b/honeyd.spec
index 2f7a429..47ded62 100644
--- a/honeyd.spec
+++ b/honeyd.spec
@@ -1,7 +1,7 @@
 Summary: Honeypot daemon
 Name: honeyd
 Version: 1.5c
-Release: 23%{?dist}
+Release: 24%{?dist}
 License: GPLv2+ and BSD
 Group: Applications/Internet
 URL: http://www.honeyd.org/
@@ -21,6 +21,7 @@ Patch5: honeyd-1.5c-lt.patch
 Patch6: honeyd-1.5c-extint.patch
 Patch7: honeyd-1.5c-libevent2.patch
 Patch8: honeyd-1.5c-automake13.patch
+Patch9: honeyd-format-security.patch
 Requires: perl-SNMP_Session
 Requires(post): systemd-units
 Requires(preun): systemd-units
@@ -50,6 +51,7 @@ cp -p %{SOURCE6}  ./
 %patch6 -p1 -b .extint
 %patch7 -p1 -b .libevent2
 %patch8 -p1 -b .automake13
+%patch9 -p1
 
 sed -i 's,arpd,farpd,' arpd/arpd.8
 
@@ -151,6 +153,9 @@ fi
 %{_mandir}/man8/farpd.8*
 
 %changelog
+* Fri Oct 03 2014 Marcin Juszkiewicz <mjuszkiewicz at redhat.com> - 1.5c-24
+- fix syslog() calls so -format-security works
+
 * Sat Aug 16 2014 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.5c-23
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild
 
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/honeyd.git/commit/?h=master&id=dad79908a0309c058007572b2bd5c51c37430377


More information about the scm-commits mailing list