pghmcfc pushed to perl-RRD-Simple (master). "Tidy up spec (..more)"

[notifications at fedoraproject.org]

>From 7574ef0dd8017059a8fb630bb8749866b62b5fa7 Mon Sep 17 00:00:00 2001
From: Paul Howarth <paul at city-fan.org>
Date: Tue, 21 Apr 2015 15:31:39 +0100
Subject: Tidy up spec

- Classify buildreqs by usage
- Drop %defattr, redundant since rpm 4.4
- Use %license where possible

diff --git a/perl-RRD-Simple.spec b/perl-RRD-Simple.spec
index 3c92f4b..130744f 100644
--- a/perl-RRD-Simple.spec
+++ b/perl-RRD-Simple.spec
@@ -3,7 +3,7 @@
 
 Name:		perl-RRD-Simple
 Version:	1.44
-Release:	19%{?dist}
+Release:	20%{?dist}
 Summary:	Simple interface to create and store data in RRD files
 Group:		Development/Libraries
 License:	ASL 2.0
@@ -11,20 +11,38 @@ URL:		http://search.cpan.org/dist/RRD-Simple
 Source0:	http://search.cpan.org/CPAN/authors/id/N/NI/NICOLAW/RRD-Simple-%{version}.tar.gz
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:	noarch
+# Module Build
+BuildRequires:	perl
+BuildRequires:	perl(Config)
+BuildRequires:	perl(Module::Build)
+# Module Runtime
 BuildRequires:	perl(Carp)
+BuildRequires:	perl(Data::Dumper)
 BuildRequires:	perl(Exporter)
 BuildRequires:	perl(File::Basename)
+BuildRequires:	perl(File::Copy)
 BuildRequires:	perl(File::Spec)
-BuildRequires:	perl(Module::Build)
+BuildRequires:	perl(File::Temp)
 BuildRequires:	perl(POSIX)
 BuildRequires:	perl(RRDs)
+BuildRequires:	perl(strict)
+BuildRequires:	perl(vars)
+BuildRequires:	perl(warnings)
+# Test Suite
+BuildRequires:	perl(lib)
 BuildRequires:	perl(Test::More)
+# Optional Tests
 BuildRequires:	perl(Test::Pod)
 BuildRequires:	perl(Test::Pod::Coverage)
+# Runtime
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires:	perl(Data::Dumper)
+Requires:	perl(File::Copy)
+Requires:	perl(File::Temp)
 
+# Optional test dependency that breaks tests
 # https://rt.cpan.org/Public/Bug/Display.html?id=46193
 BuildConflicts:	perl(Test::Deep)
-Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 # Move to unversioned documentation directories from F-20
 # https://fedoraproject.org/wiki/Changes/UnversionedDocdirs
@@ -62,12 +80,12 @@ if you do not need to, nor want to, bother defining custom RRA definitions.
 
 %build
 # Prevent call-home query/timeout; not strictly necessary
-AUTOMATED_TESTING=1 perl Build.PL installdirs=vendor
+AUTOMATED_TESTING=1 perl Build.PL --installdirs=vendor
 ./Build
 
 %install
 rm -rf %{buildroot}
-./Build install destdir=%{buildroot} create_packlist=0
+./Build install --destdir=%{buildroot} --create_packlist=0
 %{_fixperms} %{buildroot}
 
 %check
@@ -77,16 +95,25 @@ LC_ALL=C ./Build test
 rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root,-)
-%doc Changes LICENSE NOTICE README examples/ t/
+%if 0%{?_licensedir:1}
+%license LICENSE NOTICE
+%else
+%doc LICENSE NOTICE
+%endif
+%doc Changes README examples/ t/
 %dir %{perl_vendorlib}/RRD/
 %dir %{perl_vendorlib}/RRD/Simple/
 %{perl_vendorlib}/RRD/Simple.pm
 %doc %{perl_vendorlib}/RRD/Simple/Examples.pod
-%{_mandir}/man3/RRD::Simple.3pm*
-%{_mandir}/man3/RRD::Simple::Examples.3pm*
+%{_mandir}/man3/RRD::Simple.3*
+%{_mandir}/man3/RRD::Simple::Examples.3*
 
 %changelog
+* Tue Apr 21 2015 Paul Howarth <paul at city-fan.org> - 1.44-20
+- Classify buildreqs by usage
+- Drop %%defattr, redundant since rpm 4.4
+- Use %%license where possible
+
 * Thu Aug 28 2014 Jitka Plesnikova <jplesnik at redhat.com> - 1.44-19
 - Perl 5.20 rebuild
 
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/perl-RRD-Simple.git/commit/?h=master&id=7574ef0dd8017059a8fb630bb8749866b62b5fa7