jplesnik pushed to perl-Mail-Alias (master). "Remove using of 'defined' for an array (RT#101356); Modernize spec"

[notifications at fedoraproject.org]

>From 42aaa61f65c248e11e90c0d73af9d79a66d486a5 Mon Sep 17 00:00:00 2001
From: Jitka Plesnikova <jplesnik at redhat.com>
Date: Thu, 23 Apr 2015 09:55:37 +0200
Subject: Remove using of 'defined' for an array (RT#101356);Modernize spec


diff --git a/Mail-Alias-1.12-Do-not-used-defined-for-array.patch b/Mail-Alias-1.12-Do-not-used-defined-for-array.patch
new file mode 100644
index 0000000..32ac185
--- /dev/null
+++ b/Mail-Alias-1.12-Do-not-used-defined-for-array.patch
@@ -0,0 +1,12 @@
+diff -up Mail-Alias-1.12/Alias.pm.orig Mail-Alias-1.12/Alias.pm
+--- Mail-Alias-1.12/Alias.pm.orig	2015-04-23 09:26:23.489249411 +0200
++++ Mail-Alias-1.12/Alias.pm	2015-04-23 09:27:06.639992941 +0200
+@@ -82,7 +82,7 @@ sub format {
+  my $pkg = "Mail::Alias::" . $fmt;
+ 
+  croak "Unknown format '$fmt'"
+-  unless defined @{$pkg . "::ISA"};
++  unless @{$pkg . "::ISA"};
+ 
+  bless $me, $pkg;
+ }
diff --git a/perl-Mail-Alias.spec b/perl-Mail-Alias.spec
index 05224e3..5da833b 100644
--- a/perl-Mail-Alias.spec
+++ b/perl-Mail-Alias.spec
@@ -1,15 +1,18 @@
 Name:           perl-Mail-Alias
 Version:        1.12
-Release:        25%{?dist}
+Release:        26%{?dist}
 Summary:        Module for manipulating e-mail alias files
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Mail-Alias/
 Source0:        http://www.cpan.org/authors/id/Z/ZE/ZELT/Mail-Alias-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+# 'defined' should not be used for an array RT#101356
+Patch1:         Mail-Alias-1.12-Do-not-used-defined-for-array.patch
 BuildArch:      noarch
+BuildRequires:  perl(Carp)
 BuildRequires:  perl(ExtUtils::MakeMaker)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires:  perl(vars)
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 This module allows direct manipulation of various types of E-Mail
@@ -20,34 +23,31 @@ formats.
 
 %prep
 %setup -q -n Mail-Alias-%{version}
+%patch1 -p1
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
+make pure_install DESTDIR=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
 %{_fixperms} $RPM_BUILD_ROOT/*
 
 %check
 make test
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files
-%defattr(-,root,root,-)
 %doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
 
 %changelog
+* Thu Apr 23 2015 Jitka Plesnikova <jplesnik at redhat.com> - 1.12-26
+- Remove using of 'defined' for an array (RT#101356)
+- Update BR
+- Modernize spec
+
 * Wed Aug 27 2014 Jitka Plesnikova <jplesnik at redhat.com> - 1.12-25
 - Perl 5.20 rebuild
 
@@ -117,7 +117,7 @@ Rebuild for new perl
 - Cleanup
 - Took over maintainership
 
-* Fri Apr  7 2005 Michael Schwendt <mschwendt[AT]users.sf.net>
+* Wed Apr  6 2005 Michael Schwendt <mschwendt[AT]users.sf.net>
 - rebuilt
 
 * Thu Oct  2 2003 Michael Schwendt <rh0212ms[AT]arcor.de> 0:1.12-0.fdr.3
-- 
cgit v0.10.2


	http://pkgs.fedoraproject.org/cgit/perl-Mail-Alias.git/commit/?h=master&id=42aaa61f65c248e11e90c0d73af9d79a66d486a5