Fedora Core 1 Test Update: mc-4.6.0-8.3
Leonard den Ottolander
leonard at den.ottolander.nl
Sat Jan 31 02:49:18 UTC 2004
Hello Bill, Jakub,
> This is an update to the previous testing update, 4.6.0-8.1. New changes
> listed below.
Note that 8.1 is a SECURITY fix but was never announced. You should
upgrade to 8.1!
> - update php.syntax file (#112645)
> - fix crash with large syntax file (#112644)
I am very glad you included the php.syntax file, but the patch I
uploaded for #112644 is buggy, as I found out and stated in that bug
report.
When running this version (8.3) I do still see a segfault when editing
php files.
Although just increasing MAX_WORDS_PER_CONTEXT to 4096 doesn't really
solve the cause of the segfault, at least it makes mc usable with most
large syntax files, like this one included in 8.3.
--- mc-4.6.0/edit/syntax.c.000 2002-12-15 19:55:53.000000000 +0100
+++ mc-4.6.0/edit/syntax.c 2003-12-26 01:06:51.000000000 +0100
@@ -42,7 +42,7 @@
#define UNKNOWN_FORMAT "unknown"
-#define MAX_WORDS_PER_CONTEXT 1024
+#define MAX_WORDS_PER_CONTEXT 4096
#define MAX_CONTEXTS 128
#define RULE_ON_LEFT_BORDER 1
has worked for me for over a month with this > 128K php.syntax file.
The included patch does not.
Either this patch should be fixed/redone or MAX_WORDS_PER_CONTEXT
increased to 4096. And everyone should upgrade to 8.1 now!
Bye,
Leonard.
--
mount -t life -o ro /dev/dna /genetic/research
More information about the test
mailing list