Question about an automated check for $RPM_OPT_FLAGS

[Adam Williamson]

On Fri, 2011-06-03 at 06:59 -0500, Bruno Wolff III wrote:
> On Fri, Jun 03, 2011 at 06:27:27 -0500,
>   Bruno Wolff III <bruno at wolff.to> wrote:
> > On Fri, Jun 03, 2011 at 06:46:00 +0200,
> >   Ralf Corsepius <rc040203 at freenet.de> wrote:
> > > 
> > > If this package was honouring $RPM_OPT_FLAGS, the contents of 
> > > $RPM_OPT_FLAGS would be found inside of this compiler call.
> > 
> > Thanks. I wrongly assumed that setting the CXX flags would result in
> > them getting used. I'll take a deeper look at what is going on.
> 
> I'll blame it being late when I got home last night and looked at this.
> For some reason I thought the build information was being hidden when
> it clearly isn't and just focussed on the CXX flags being set.
> 
> Two of the CMakelists.txt files set CMAKE_CXX_FLAGS to -Wall overriding
> what's passed in. I commented those out and now things appear to look
> better.

It's always worth sending a patch upstream in this case. I think it
should be quite easy, IIRC you can use += in CMake to append instead of
overwriting, but check it out, IMBW.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Fedora Talk: adamwill AT fedoraproject DOT org
http://www.happyassassin.net