[fedora-virt] Spec weirdness

[Jesse Keating]

I'm looking at the spec file for libguestfs, and all I can say is WTF.
There is a lot of crazyness going on in this spec, chroots within
chroots, making a repo of yum cache packages and using it again, calling
qemu, and none of it is really documented in the spec as for what and
why things are done this way.

The review for this is extremely light on comments regarding the spec
file construction as well, it looks very suspiciously like "it built and
passed rpmlint, let it in!"

I'd really like to see some comments around what's going on here, and
maybe some discussion on public lists of what you're trying to do and
whether or not there are better ways to do that within our buildsystem.

-- 
Jesse Keating
Fedora -- Freedom² is a feature!
identi.ca: http://identi.ca/jkeating
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.fedoraproject.org/pipermail/virt/attachments/20090810/50e72a29/attachment.bin