[fedora-virt] [fedora-specific libvirt PATCH] qemu: replace deprecated fedora-13 machine type with pc-0.13

[Amit Shah]

On (Mon) 12 Dec 2011 [17:00:57], Eric Blake wrote:
> Testing results - upgrading libvirtd with a running domain of type
> fedora-13 passed, and I noticed all persistent configurations were
> properly upgraded as part of the new libvirtd.  All attempts to modify a
> running fedora-13 machine were converted to pc-0.13, as expected by the
> code.
> 
> HOWEVER, pc-0.13 is wrong.  I had one rather significant test failure:
> 
> I did this on a running domain:
> old libvirt: virsh save dom file.sav
> upgrade libvirtd
> new libvirt: virsh restore file.sav
> 
> and got a cryptic failure:
> 
> error: Failed to restore domain from file.sav
> error: internal error process exited while connecting to monitor: char
> device redirected to /dev/pts/5
> Unknown savevm section or instance 'kvmclock' 0
> load of migration failed
> 
> But I then hand-hacked the save file (well, actually, I did:
> 
> sed "s/='fedora-13'/='pc-0.14'  /" file.sav > file.sav2
> 
> at which point:
> new libvirt: virsh restore file.sav2
> 
> succeeded.  My conclusion?  Qemu must be saving the machine type
> somewhere in the migration file format (virsh save is a migration to
> file, which means you'd see the same behavior when migrating between two
> machines); and pc-0.13 is missing something related to kvmclock, and is
> thus unable to reparse the migration data.  But pc-0.14 works just fine,
> which means your patch is _almost_ right - just change fedora-13 to
> pc-0.14, and I think we're set.

The fedora-13 machine type was just a slightly modified pc-0.12
machine type, so using pc-0.12 should be the safest.


		Amit