Javascript Error on fp.o

Sijis Aviles sijis.aviles at gmail.com
Wed Jul 22 15:32:36 UTC 2009


All,

A javascript error on fp.o was noticed a few days ago and brought to
our attention on #fedora-admin. The error was noticed on IE7 and i
could also confirm it on IE6.

I think i know what the problem is, it was the do with an extra comma
in the banner[] array.

I'm attaching the diff/fix for it

--
diff -u banner-original.js banner-fix.js
--- banner-original.js	2009-07-22 10:03:07.000000000 -0500
+++ banner-fix.js	2009-07-22 10:03:07.000000000 -0500
@@ -26,7 +26,8 @@
     "Fedora Community Podcast",
     "https://fedoraproject.org/wiki/F11_release_podcasts#Fedora_Community_portal",
     4
-  ],
+  ]
+//,
 //  ["http://fedoraproject.org/static/images/banners/fedorawn.png",
"Fedora Weekly News", "http://fedoraproject.org/wiki/FWN/LatestIssue",
1],
 //  ["http://fedoraproject.org/static/images/banners/fedora.org_devfu_widget.jpg",
"Dev Fu", "http://developer.redhatmagazine.com/", 1],
 //  ["http://fedoraproject.org/static/images/banners/fedora.org_rhm_widget.jpg",
"Red Hat Magazine", "http://redhatmagazine.com/", 1],
--

Can someone please test this and confirm it does not cause issues on
other browsers?

Thanks,

Sijis




More information about the websites mailing list