[389-devel] strcasestr vs. PL_strcasestr

[Nathan Kinder]

On 03/07/2014 06:32 AM, Rich Megginson wrote:
> On 03/07/2014 07:15 AM, Carsten Grzemba wrote:
>> Hi Nathan,
>>
>> is there special reason why you use /strcasestr/ in ACL plugin instead
>> of /PL_strcasestr/.
>> It presents me some headache to build 1.3.2 on Solaris 10.
>> https://git.fedorahosted.org/cgit/389/ds.git/commit/ldap/servers/plugins/acl?id=95214606df95deb1cf9a30044fe64f780c030b34
> 
> No, there is no reason to use strcasestr.  We should be using
> PL_strcasestr for portability.

+1.  This file wasn't using any of the NSPR string functions, so I
simply avoided converting it to use NSPR to keep the changes minimal.
If that's causing a portability problem, it should be changed.

Thanks,
-NGK

> 
>>
>> Carsten
>>
>>
>> Am 06.03.14 schrieb *Noriko Hosoi * <nhosoi at redhat.com>:
>>> https://fedorahosted.org/389/ticket/47731
>>>
>>> https://fedorahosted.org/389/attachment/ticket/47731/0001-Ticket-47731-A-tombstone-entry-is-deleted-by-ldapdel.patch
>>>
>>> Description: A tombstone deletion by ldapdelete op from client is
>>> supposed to fail. The failure from SLAPI_PLUGIN_BETXNPOSTOPERATION was
>>> ignored in 389-ds-base-1.2.11 plugin_call_func and it was not passed to
>>> the backend to abort. This patch added the check in the same way as in
>>> 389-ds-base-1.3.1 and newer.
>>> --
>>> 389-devel mailing list
>>> 389-devel at lists.fedoraproject.org
>>> https://admin.fedoraproject.org/mailman/listinfo/389-devel
>>
>>
>> --
>> 389-devel mailing list
>> 389-devel at lists.fedoraproject.org
>> https://admin.fedoraproject.org/mailman/listinfo/389-devel
> 
> 
> 
> --
> 389-devel mailing list
> 389-devel at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/389-devel
>