[PATCH 0/2] Allow rpkg to use custom source metadata file and format

[Mathieu Bridon]

On Wed, 2014-07-02 at 15:45 -0500, Pat Riehecky wrote:
> The 'sha summed source file(s)' for git.centos.org is hosted under the 
> following pattern:
> 
> https://git.centos.org/sources/<packagename>/<branch>/<shasum>
> 
> Whereas rpkg's expects (from line 1489 of __init__.py):
> 
> https://git.centos.org/sources/<packagename>/<filename>/<shasum>/<filename>
> 
> For example, when using the default URL path rpkg attempts to download 
> the following file:
> https://git.centos.org/sources/a2ps/SOURCES/a2ps-4.14.tar.gz/365abbbe4b7128bf70dad16d06e23c5701874852/SOURCES/a2ps-4.14.tar.gz
> 
> The path I wish to set for rpkg to use is:
> https://git.centos.org/sources/a2ps/c7/365abbbe4b7128bf70dad16d06e23c5701874852

[note: I'm not the rpkg upstream maintainer]

Generally I don't think these things are configuration: they should not
be modified by a user of the tools, they merely correspond to default
internal values of each tool.

As such, I wouldn't be in favour of adding them to the config file. (but
then again, I'm not the upstream maintainer :) )

On the other hand, adding a new keyword argument to the Command.sources
method implies that a given API-using tool could call it with different
urls, which could make sense if your tool can point to different
lookaside caches with different url structures. (at my previous job, we
had our own pyrpkg-based tool called nbpkg which could interact both
with our own infrastructure and the Fedora one. We had the same url
structure for lookaside caches though)


-- 
Mathieu