[PATCH 0/2] Allow rpkg to use custom source metadata file and format

[Dennis Gilmore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 2 Jul 2014 15:45:50 -0500
Pat Riehecky <riehecky at fnal.gov> wrote:

> On 07/02/2014 02:40 PM, Dennis Gilmore wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On Wed, 2 Jul 2014 11:21:13 -0500
> > Pat Riehecky <riehecky at fnal.gov> wrote:
> >
> >> On 07/02/2014 11:11 AM, Pat Riehecky wrote:
> >>> From: Pat Riehecky <riehecky at fnal.gov>
> >>>
> >>> Over at the CentOS project they are looking into an rpkg based
> >>> tool, but due to the hard coded filename for external sourecs, a
> >>> lot of code is duplicated.
> >>>
> >>> The attached patch preserves the existing behavior, but allows a
> >>> hook into the 'sources' function so that other metadata files can
> >>> be consulted.
> >>>
> >>> The format of the url in the CentOS structure is also different.
> >>> However, I've not (yet?) taken a stab at making that customizable.
> >>>
> >>> Pat Riehecky (2):
> >>>     Allow custom 'sources' metadata file
> >>>     Added optional 'valsep' for metadata files not seperated by
> >>> '  '
> >>>
> >>>    src/pyrpkg/__init__.py |    6 +++---
> >>>    1 files changed, 3 insertions(+), 3 deletions(-)
> >>>
> >> For the custom url format, would a config entry or optional arg to
> >> Commands.sources be preferred?
> >>
> >> Pat
> >>
> > what kind of custom url format are you looking at? the url format
> > today is what koji needs.
> >
> > Dennis
> 
> The 'sha summed source file(s)' for git.centos.org is hosted under
> the following pattern:
> 
> https://git.centos.org/sources/<packagename>/<branch>/<shasum>
> 
> Whereas rpkg's expects (from line 1489 of __init__.py):
> 
> https://git.centos.org/sources/<packagename>/<filename>/<shasum>/<filename>
> 
> For example, when using the default URL path rpkg attempts to
> download the following file:
> https://git.centos.org/sources/a2ps/SOURCES/a2ps-4.14.tar.gz/365abbbe4b7128bf70dad16d06e23c5701874852/SOURCES/a2ps-4.14.tar.gz
> 
> The path I wish to set for rpkg to use is:
> https://git.centos.org/sources/a2ps/c7/365abbbe4b7128bf70dad16d06e23c5701874852

ewww, seriously eww. the tooling would need to rename the file it gets
to the name in the spec file. this I think doesn't belong in rpkg,
whatever tooling centos people come up with will have to replace rpkgs
function with its own version. I would strongly advocate for centos to
rethink how they are doing it and follow the standard convention.
 
> 
> Sorry for not being clear earlier,
No Problem
 
Dennis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJTtWWTAAoJEH7ltONmPFDRNFYQAIQwTDBnOyuYEzryzrP0sG4E
ZJbYhQXoQmnSK3ImhdEGgj203HnSnyLLYFgGT+qFBqOBCV5zNA0bkMJK55JTjWw4
IDoV/x4JrYATnyxagVJdgtIEgQq5r05TSnK8sAemGcPTE4USs8aoMGwEz5HveRSW
9jYwhozlvl6KFd6thxVQZRWd0hN6bVnNguDtq4RKgsZeulhQrLqcIHkK1/jZNO3A
Dn1wzZL1LSeeg6uJb0zMNPPCvVomh9nLFJW7yQXc6i+na+9AK718j/ssAYW3BwUG
S8Cq5j3ZO1sG8+pZ6Kh/BI+di2qbEjnMFLD6g1k9N2pvkBxEv/nKp0SMLMIY3PhS
UrewFQ+Hdc7yn/JDIeI4qLQ0s5pFqxvvL6ccLnMQyTLJlgDSjcbu4U5B7P5M6zSO
2RhlOJzgDzg7B4LQko9vyYT6IUOPVMC6duJkaESorEHB88W998o+YS7HpoegUrUO
02JpMwRVuNMjgZw4v3an5X7VPKSaJaQsagIJXhcZYUa+vUkMr4xHoUS4LbOyl1r8
KX1zipRFKTk0XinYm87IuS9qXq4dcNE/zhvq8/JMQYVLkuwv4Noofww4cWobcL6V
5wJKLprRrLTsWWGAQNyr+incpE4il11W/tZfHYkiS7kE+4sLkL9987e2nLnXtlHU
sZEhjBaIAAndnYJBUv6M
=ZAdf
-----END PGP SIGNATURE-----