[PATCH] Don't retry on SSL failures

[Peter Robinson]

On Wed, Jul 22, 2015 at 8:28 AM, Mathieu Bridon <bochecha at daitauha.fr> wrote:
> On Wed, 2015-07-22 at 00:45 +0100, Peter Robinson wrote:
>> This has actually caused me issues with newRepo on el6. I get the
>> following traceback from kojid:
>
> Are you sure this is due to this patch? Looking at the traceback, it
> doesn't seem to be passing through the lines I added. :-/
>
> Also, all the patch did, is to stop retrying on an SSL error, because
> no matter how many times Koji retries, you'd still get the same SSL
> error.
>
> Which means if you're getting an error because of this patch, then
> you'd have had it without the patch as well, only after a few retries.
>
> Which means if this patch is responsible for the error you got, then
> I'd say there already is a problem with your SSL setup.
>
> But in any case, I really don't see how this patch could have caused
> your problem. :-/

Well as far as I could tell it was the only recent change to that code
and commenting it out everything started working again. I might have
another one that seems related, might not be. This time when signing
updates using secondary-sigul, network connection was contrained (ISP
having traffic issues) with low bandwidth. Again only change around
this was the update to koji 1.10 client.

Passphrase for fedora-22-secondary:
2015-07-22 11:26:30,139 INFO: Setting up koji session
2015-07-22 11:26:34,605 INFO: Getting builds from f22-updates
2015-07-22 11:35:45,683 INFO: Got 1712 builds
2015-07-22 11:35:45,684 INFO: Getting build IDs from Koji
Traceback (most recent call last):
  File "./sigulsign_unsigned.py", line 534, in <module>
    build_ids, buildID_errors = kojihelper.get_build_ids(buildNVRs)
  File "./sigulsign_unsigned.py", line 214, in get_build_ids
    for build, result in zip(nvrs, self.kojisession.multiCall()):
  File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1986,
in multiCall
    ret = self._callMethod('multiCall', (calls,), {})
  File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1920,
in _callMethod
    return self._sendCall(handler, headers, request)
  File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1831,
in _sendCall
    return self._sendOneCall(handler, headers, request)
  File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1853,
in _sendOneCall
    ret = self._read_xmlrpc_response(response, handler)
  File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1888,
in _read_xmlrpc_response
    chunk = response.read(8192)
  File "/usr/lib64/python2.7/httplib.py", line 612, in read
    s = self.fp.read(amt)
  File "/usr/lib64/python2.7/socket.py", line 384, in read
    data = self._sock.recv(left)
  File "/usr/lib/python2.7/site-packages/koji/ssl/SSLConnection.py",
line 140, in recv
    return con.recv(bufsize, flags)
  File "/usr/lib/python2.7/site-packages/OpenSSL/SSL.py", line 995, in recv
    self._raise_ssl_error(self._ssl, result)
  File "/usr/lib/python2.7/site-packages/OpenSSL/SSL.py", line 864, in
_raise_ssl_error
    raise SysCallError(-1, "Unexpected EOF")
OpenSSL.SSL.SysCallError: (-1, 'Unexpected EOF')