[PATCH] Don't retry on SSL failures

Dustin C. Hatch dustin.hatch at firemon.com
Wed Jul 22 23:04:10 UTC 2015


On 2015-07-22 02:28, Mathieu Bridon wrote:
> On Wed, 2015-07-22 at 00:45 +0100, Peter Robinson wrote:
>> This has actually caused me issues with newRepo on el6. I get the
>> following traceback from kojid:
>
> Are you sure this is due to this patch? Looking at the traceback, it
> doesn't seem to be passing through the lines I added. :-/

That's because a plain `raise` doesn't modify the traceback.

> Also, all the patch did, is to stop retrying on an SSL error, because
> no matter how many times Koji retries, you'd still get the same SSL
> error.

Not necessarily. The EOF error is pretty commonly transient, and 
retrying once or twice is typically sufficient to work around it.

-- 
♫Dustin



More information about the buildsys mailing list