Package Review Request: python-picloud

Vijay N. Majagaonkar vijay.majagaonkar at gmail.com
Mon Mar 5 15:13:55 UTC 2012


I am not reviewer but I think it make sense following things are good
to incorporate

>># These packages are not require for python >=2.6 but required for python
= 2.5

>>Requires:       python >= 2.5

I think your Requires: must be python = 2.5

>>%setup -q -n cloud-%version

is that version should be %{version}

>> mkdir -p ...

>>cp -p ...

It will be good if you make use of macro like %{__cp}



;)

V!jay

On Mon, Mar 5, 2012 at 1:00 AM, Amit Saha <droidery at gmail.com> wrote:

> Hello:
>
> Could someone please review my first package: https://bugzilla.redhat.com/
> **show_bug.cgi?id=799810<https://bugzilla.redhat.com/show_bug.cgi?id=799810>?
>
> Since, this is my first, I am in need of a sponsor (FAS: amitksaha)
>
> Thanks a lot !
> -Amit
> --
> http://echorand.me
> --
> devel mailing list
> devel at lists.fedoraproject.org
> https://admin.fedoraproject.**org/mailman/listinfo/devel<https://admin.fedoraproject.org/mailman/listinfo/devel>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/devel/attachments/20120305/f7e78703/attachment.html>


More information about the devel mailing list