really stop "really" commits (really!)

[T.C. Hollingsworth]

On Mon, Dec 16, 2013 at 2:29 AM, Vít Ondruch <vondruch at redhat.com> wrote:
> It prevents even local commits if I am not wrong.

Yeah, to only do it when commits are pushed would mean to do it as a
pre-receive hook on the dist-git server, which makes things
significantly more complicated.

Plus aborting right when you commit so you can just fix it real quick
is much nicer than aborting it after you've already entered your SSH
passphrase and then having to go back and amend the commit, etc.

> I do commit locally
> although I probably don't want push the snapshot sources, because I update
> them later, when time comes.

This should happen rarely enough that having to use `git commit
--no-verify` to bypass it wouldn't be too much trouble?

I think that in general it's reasonable to expect that anything
committed to a dist-git clone is intended to be pushed upstream to
dist-git.  If you want to play around, use a topic branch.  If it's
really a one-off, just bypass the check that one time.

> http://pkgs.fedoraproject.org/cgit/rubygem-activeresource.git/tree/rubygem-activeresource.spec?h=f18#n86
> http://pkgs.fedoraproject.org/cgit/rubygem-activerecord.git/tree/rubygem-activerecord.spec?h=f18#n95

These are fine, since they use %{PATCH0}.  I guess I should have
mentioned it checks for both uppercase and lowercase forms, sorry.

-T.C.