Rough-Patch for F18 kernel.spec: apply modsign patches even for vanilla builds

[Josh Boyer]

On Tue, Nov 06, 2012 at 02:29:08PM +0100, Thorsten Leemhuis wrote:
> Hi!
> 
> Find below a rough, illustrative patch that fixes the following error when you try to build a vanilla kernel with kernel.spec from F18 git:
> 
> > + echo BUILDING A KERNEL FOR PAE i686...
> > BUILDING A KERNEL FOR PAE i686...
> > + perl -p -i -e 's/^SUBLEVEL.*/SUBLEVEL = 6/' Makefile
> > + perl -p -i -e 's/^EXTRAVERSION.*/EXTRAVERSION = -3.vanilla.stable.knurd.1.fc18.i686.PAE/' Makefile
> > + make -s mrproper
> > + cp configs/kernel-3.6.6-i686-PAE.config .config
> > + cp /builddir/build/SOURCES/x509.genkey .
> > + chmod +x scripts/sign-file
> > chmod: cannot access 'scripts/sign-file': No such file or directory
> > RPM build errors:
> > error: Bad exit status from /var/tmp/rpm-tmp.06kdJq (%build)
> >     Bad exit status from /var/tmp/rpm-tmp.06kdJq (%build)
> 
> I didn't check, but I assume the change "Update modsign to what is currently in 3.7-rc2" was the point where the problem was introduced.

Yes, probably.  But I don't think applying those patches for vanilla
builds is the right fix here.  If you apply them, you wouldn't be
building a vanilla 3.6.x kernel.  That seems to defeat the purpose of
having a vanilla kernel to test with.

We could make the chmod conditional on the file existing, but I think
even with that we might run into issues later on during the build in the
debuginfo generation section where it's calling the modules_sign target,
and the signing script for mod-extras.  That might need to get wrapped in
a %{nopatches} check too.

For now, try just doing:

	chmod +x scripts/sign-file || true

and see if the build fails later (I expect it would).  I'm chasing a
different issue with F18 today, so I won't have time to fix this
properly, but I'll try and get to it later this week.

josh