Rough-Patch for F18 kernel.spec: apply modsign patches even for vanilla builds

[Thorsten Leemhuis]

Hi!

On 06.11.2012 14:43, Josh Boyer wrote:
> On Tue, Nov 06, 2012 at 02:29:08PM +0100, Thorsten Leemhuis wrote:
>> Find below a rough, illustrative patch that fixes the following error when you try to build a vanilla kernel with kernel.spec from F18 git:
 > […]
>> I didn't check, but I assume the change "Update modsign to what is currently in 3.7-rc2" was the point where the problem was introduced.
>
> Yes, probably.  But I don't think applying those patches for vanilla
> builds is the right fix here.

>  If you apply them, you wouldn't be
> building a vanilla 3.6.x kernel.  That seems to defeat the purpose of
> having a vanilla kernel to test with.

Sure. But well, as I wrote on the wiki page that explains the repos, 
sometimes I might have to apply patches. But yeah, in this case a proper 
fix is definitely better.

> We could make the chmod conditional on the file existing, but I think
> even with that we might run into issues later on during the build in the
> debuginfo generation section where it's calling the modules_sign target,
> and the signing script for mod-extras.  That might need to get wrapped in
> a %{nopatches} check too.
>
> For now, try just doing:
>
> 	chmod +x scripts/sign-file || true
>
> and see if the build fails later (I expect it would).  I'm chasing a
> different issue with F18 today, so I won't have time to fix this
> properly, but I'll try and get to it later this week.

Np; I'll take a closer look on the weekend when I'm home again.

CU
knurd