[Bug 825557] Review Request: mingw-clucene - CLucene 2.3.3.4 built for MinGW

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=825557

--- Comment #4 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> ---
(In reply to comment #3)
> I have uploaded an updated spec and src.rpm file to
> the same URLs as above if anyone else wants to take a look.

Please bump the release and upload a new .src.rpm every time you make a change.
This makes it easier to compare changes between versions

Some additional review comments:
- The CMake argument -DDISABLE_MULTITHREADING=ON and -D_CL_HAVE_WIN32_THREADS=0
are used in both the MINGW32_CMAKE_ARGS and the MINGW64_CMAKE_ARGS. To reduce
duplication, you might want to move these to the %mingw_cmake call
- The %clean section can be removed completely
- Why are the files %{mingw32_libdir}/CLuceneConfig.cmake and
%{mingw64_libdir}/CLuceneConfig.cmake dropped but not the files
%{mingw32_libdir}/CLucene/CLuceneConfig.cmake and
%{mingw64_libdir}/CLucene/CLuceneConfig.cmake. Shouldn't these two files be
dropped as well?
- The CMake arguments -DLUCENE_SYS_INCLUDES:PATH=%{mingw32_libdir} and
-DLUCENE_SYS_INCLUDES:PATH=%{mingw64_libdir} shouldn't be needed for MinGW
packages. It looks like the native Fedora CLucene package uses it for multilib
support, but as Fedora MinGW doesn't use multilib this CMake argument shouldn't
be needed for this package

(In reply to comment #3)
> rwmjones said on
> Freenode he is overburdened with sponsorees already. I'm still looking for a
> package sponsor for this package.

One of the things you could do to attract potential sponsors is by helping out
with reviewing other packages so you can demonstrate your understanding of the
Fedora Packaging Guidelines. Here are some packages which might be interesting
to help reviewing:

https://bugzilla.redhat.com/show_bug.cgi?id=832007 - mingw-webkitgtk3
https://bugzilla.redhat.com/show_bug.cgi?id=830388 - mingw-libarchive
https://bugzilla.redhat.com/show_bug.cgi?id=830387 - mingw-xz

-- 
You are receiving this mail because:
You are on the CC list for the bug.