[Bug 1206080] Review Request: antlr4 - Java parser generator

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1206080

Raphael Groner <projects.rg at smart.ms> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |projects.rg at smart.ms



--- Comment #2 from Raphael Groner <projects.rg at smart.ms> ---
Some things first from a manual review of your spec file:

> %bcond_without bootstrap

What's this for?

> # Upstream uses an experimental bulid tool (http://bildtool.org/),

So why not package this tool in first place and use it as a dependency?

> # Prebuild binaries, used for bootstrapping only

I would not suggest to use copr therefore. You should look for a more
statically available location to provide those binaries. Further, it is not
allowed to ship prebuild binaries in an official Fedora package, at least not
without allowed exception.

> %prep

Use cp -p here to preserve timestamps.

> %files

You have to include the license file in each subpackage. Alternatively you
should require the runtime subpackage for all other packages incl. the main
package that you build here from the source tarball.

When the above things are fixed, I could do also an official fedora-review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component