[Bug 1206080] Review Request: antlr4 - Java parser generator

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1206080



--- Comment #3 from Mikolaj Izdebski <mizdebsk at redhat.com> ---
(In reply to Raphael Groner from comment #2)
> Some things first from a manual review of your spec file:
> 
> > %bcond_without bootstrap
> 
> What's this for?

This allows the same SRPM to be built either in bootstrap or non-bootstrap mode
by passing "--with bootstrap" or "--without bootstrap" to tools like rpmbuild
or mock.

> > # Upstream uses an experimental bulid tool (http://bildtool.org/),
> 
> So why not package this tool in first place and use it as a dependency?

Because this is not necessary and it would be impractical to do so - the build
tool downloads dependencies from network so build script would need to be
heavily patched anyways.

> > # Prebuild binaries, used for bootstrapping only
> 
> I would not suggest to use copr therefore. You should look for a more
> statically available location to provide those binaries. Further, it is not
> allowed to ship prebuild binaries in an official Fedora package, at least
> not without allowed exception.

I don't see why copr rpms shouldn't be used. Prebuilt binaries are used only
for the initial bootstrap build and will be removed afterwards. There is FPC
bootstrap exception for antlr4, see https://fedorahosted.org/fpc/ticket/517

> > %prep
> 
> Use cp -p here to preserve timestamps.

Minor issue, but I'll fix that.

> > %files
> 
> You have to include the license file in each subpackage. Alternatively you
> should require the runtime subpackage for all other packages incl. the main
> package that you build here from the source tarball.

License files don't need to be installed in antlr4 and antlr4-maven-plugin
packages because both of them depend on antlr4-runtime which includes license
text. antlr4-javadoc doesn't depend on any other antlr4 subpackage and
therefore it installs a separate copy of license text. This is in accordance
with
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component