This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch master
in repository 389-ds-base.
commit 28f69b393fd63221894bb3232b0877919854e9ea
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Thu Apr 19 15:49:58 2018 -0400
Ticket 49639 - Crash when failing to read from SASL conn
Description: This is a regression from ticket 49618, a return code
integer was reset to a unsigned int, when it needed to
remain signed. This allowed an error condition to go
unchecked, which leads to a crash caused by a large
realloc attempt from the overflowed integer result code.
https://pagure.io/389-ds-base/issue/49639
Reviewed by: mreynolds(one line commit rule)
---
ldap/servers/slapd/sasl_io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ldap/servers/slapd/sasl_io.c b/ldap/servers/slapd/sasl_io.c
index 751832b..7351148 100644
--- a/ldap/servers/slapd/sasl_io.c
+++ b/ldap/servers/slapd/sasl_io.c
@@ -189,8 +189,8 @@ sasl_io_start_packet(PRFileDesc *fd, PRIntn flags, PRIntervalTime
timeout, PRInt
unsigned char buffer[SASL_IO_BUFFER_START_SIZE];
sasl_io_private *sp = sasl_get_io_private(fd);
Connection *c = sp->conn;
- uint32_t amount = sizeof(buffer);
- uint32_t ret = 0;
+ int32_t amount = sizeof(buffer);
+ int32_t ret = 0;
uint32_t packet_length = 0;
int32_t saslio_limit;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.