ldap/servers/slapd/bind.c | 3 +++ 1 file changed, 3 insertions(+)
New commits: commit a55c91ec4c706388971323ad26e6aa7fdd63b9db Author: Mark Reynolds mareynol@redhat.com Date: Wed Feb 1 17:05:30 2012 -0500
Ticket #39 - Account Policy Plugin does not work for simple binds when PAM Pass Through Auth plugin is enabled
Bug Description: The PAM plugin, if the bind was successful, aborts the pre and post op plugins. This causes problems with post op plugins like Account Policy.
Fix Description: In do_bind(), still call the post op plugins even if the pre-op ones fail.
https://fedorahosted.org/389/ticket/39
diff --git a/ldap/servers/slapd/bind.c b/ldap/servers/slapd/bind.c index 1d860b6..4c3d25c 100644 --- a/ldap/servers/slapd/bind.c +++ b/ldap/servers/slapd/bind.c @@ -796,6 +796,9 @@ do_bind( Slapi_PBlock *pb )
slapi_pblock_set( pb, SLAPI_PLUGIN_OPRETURN, &rc ); plugin_call_plugins( pb, SLAPI_PLUGIN_POST_BIND_FN ); + } else { + /* even though preop failed, we should still call the post-op plugins */ + plugin_call_plugins( pb, SLAPI_PLUGIN_POST_BIND_FN ); } } else { send_ldap_result( pb, LDAP_UNWILLING_TO_PERFORM, NULL,
389-commits@lists.fedoraproject.org