ldap/servers/slapd/ssl.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 2b7b9cb86cd14a5ac60ee7b01d2a31aed54f3fb8
Author: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Mon Aug 11 12:26:37 2014 -0700
Ticket #47838 - harden the list of ciphers available by default
Description: Fixed a coverity issue introduced by
commit 13c0d2f7b7850676042fe05c917a7d498135324f
Coverity 12734 - Uninitialized scalar variable
diff --git a/ldap/servers/slapd/ssl.c b/ldap/servers/slapd/ssl.c
index 72abebd..1a21df0 100644
--- a/ldap/servers/slapd/ssl.c
+++ b/ldap/servers/slapd/ssl.c
@@ -354,13 +354,15 @@ _conf_setallciphers(int flag, char ***suplist, char ***unsuplist)
SECStatus rc;
PRBool setdefault = (flag == CIPHER_SET_DEFAULT) ? PR_TRUE : PR_FALSE;
PRBool enabled = (flag == CIPHER_SET_ALL) ? PR_TRUE : PR_FALSE;
- PRBool setme;
+ PRBool setme = PR_FALSE;
const PRUint16 *implementedCiphers = SSL_GetImplementedCiphers();
_conf_init_ciphers();
for (x = 0; implementedCiphers && (x < SSL_NumImplementedCiphers); x++) {
- if (!(_conf_ciphers[x].flags & CIPHER_IS_DEFAULT)) {
+ if (_conf_ciphers[x].flags & CIPHER_IS_DEFAULT) {
+ setme = PR_TRUE;
+ } else {
/*
* SSL_CipherPrefGetDefault
* If the application has not previously set the default preference,
Show replies by thread