bodhi/templates

[Luke Macken]

 bodhi/templates/master.kid  |    2 +-
 bodhi/templates/welcome.kid |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 15edfba566088639f8c4387646b28f2935c8f866
Author: Luke Macken <lmacken(a)redhat.com&gt;
Date:   Fri May 21 05:38:38 2010 -0400

    Force https on our links to bodhi's fedorahosted (#430)

diff --git a/bodhi/templates/master.kid b/bodhi/templates/master.kid
index 930fc9b..5b6c789 100644
--- a/bodhi/templates/master.kid
+++ b/bodhi/templates/master.kid
@@ -142,7 +142,7 @@ $(document).ready(function() {
         Copyright &copy; 2007-2010 Red Hat, Inc. and others.  All Rights
Reserved.<br/>
         Licensed under the GNU Public License v2 or later.<br />
         The Fedora Project is maintained and driven by the community and sponsored by Red
Hat.<br/>This is a community maintained site.  Red Hat is not responsible for
content.<br/>
-        [ <a href="http://fedoraproject.org/wiki/Legal">Legal</a>;,
<a
href="http://fedoraproject.org/wiki/Legal/TrademarkGuidelines"&...
Guidelines</a>, <a href="http://bodhi.fedorahosted.org">Source
Code</a> ]
+        [ <a href="http://fedoraproject.org/wiki/Legal">Legal</a>;,
<a
href="http://fedoraproject.org/wiki/Legal/TrademarkGuidelines"&...
Guidelines</a>, <a href="https://fedorahosted.org/bodhi">Source
Code</a> ]
     </div>
     <!-- footer END -->
 
diff --git a/bodhi/templates/welcome.kid b/bodhi/templates/welcome.kid
index 62c602a..474d870 100644
--- a/bodhi/templates/welcome.kid
+++ b/bodhi/templates/welcome.kid
@@ -32,7 +32,7 @@
                         <tr>
                             <td>
                                 <span id="bodhitip" title="Bodhi
Project Homepage">
-                                    <a
href="http://fedorahosted.org/bodhi"><img
src="${tg.url('/static/images/bodhi-icon-36.png')}" border="0"
height="36" width="36"/></a>
+                                    <a
href="https://fedorahosted.org/bodhi"><img
src="${tg.url('/static/images/bodhi-icon-36.png')}" border="0"
height="36" width="36"/></a>
                                 </span>
                             </td>
                             <td>

[Mathieu Bridon]

Hi Luke,

>  -        [ <a
> href="http://fedoraproject.org/wiki/Legal">Legal</a>;, <a
>  href="http://fedoraproject.org/wiki/Legal/TrademarkGuidelines"&...
>  Guidelines</a>, <a href="http://bodhi.fedorahosted.org">Source
> Code</a> ]
>  +        [ <a href="http://fedoraproject.org/wiki/Legal">Legal</a>;,
> <a
>  href="http://fedoraproject.org/wiki/Legal/TrademarkGuidelines"&...
>  Guidelines</a>, <a href="https://fedorahosted.org/bodhi">Source
> Code</a> ] 
[... snip ...]

I think it would have made sense to also use https for the wiki URLs, as 
linking to http causes troubles with authentication:
  1. go to http://fedoraproject.org/wiki/Legal:Main
  2. Log in
  3. go to http://fedoraproject.org/wiki/Legal/TrademarkGuidelines
  4. observe that you are not logged in

Instead, if you go to the https URL in 3, you will see that you are 
logged in.


--
Mathieu

[Luke Macken]

On Fri, May 21, 2010 at 06:47:46PM +0200, Mathieu Bridon wrote:
>  Hi Luke,
>  
>  > -        [ <a
> href="http://fedoraproject.org/wiki/Legal">Legal</a>;, <a
>  >
> href="http://fedoraproject.org/wiki/Legal/TrademarkGuidelines"&...
>  > Guidelines</a>, <a href="http://bodhi.fedorahosted.org">Source
> Code</a> ]
>  > +        [ <a
> href="http://fedoraproject.org/wiki/Legal">Legal</a>;, <a
>  >
> href="http://fedoraproject.org/wiki/Legal/TrademarkGuidelines"&...
>  > Guidelines</a>, <a
> href="https://fedorahosted.org/bodhi">Source Code</a> ]
>  
>  [... snip ...]
>  
>  I think it would have made sense to also use https for the wiki URLs, as 
>  linking to http causes troubles with authentication:
>    1. go to http://fedoraproject.org/wiki/Legal:Main
>    2. Log in
>    3. go to http://fedoraproject.org/wiki/Legal/TrademarkGuidelines
>    4. observe that you are not logged in
>  
>  Instead, if you go to the https URL in 3, you will see that you are 
>  logged in. 
Fixed in git.

Thanks,

luke