cluster: RHEL56 - gfs_controld: set last_plock_time for ownership operations

[David Teigland]

Gitweb:       
http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=...
Commit:        e8c551339350df530a99bd6006246b13b0521f12
Parent:        c5c968af388618038ca132cd0dbb01b66f1533b5
Author:        David Teigland <teigland(a)redhat.com&gt;
AuthorDate:    Wed Mar 31 16:07:05 2010 -0500
Committer:     David Teigland <teigland(a)redhat.com&gt;
CommitterDate: Thu Aug 5 16:16:28 2010 -0500

gfs_controld: set last_plock_time for ownership operations

last_plock_time was not being set for ops related to ownership mode
like "own" and "drop" which change the plock state that is saved in
checkpoints.  Not changing last_plock_time means we don't detect
that plock state has changed when it has, and may end up reusing an
old checkpoint, causing a mounting node to read incorrect resource
ownership state.

It would take a long sequence of carefully crafted steps to
intentionally hit this bug.  Something like:
1. configure plock_ownership="1"
2. node1 and node2 are mounted and have plock state
3. mount gfs on node3
4. do not do any plock operations on any nodes
5. wait for one of the nodes to send a drop message
   (this may require some artificial prodding)
6. mount gfs on node4
7. compare the plock state on node4 and the other nodes;
   the dropped plock should exist on node4, but not on the others
8. plock operations on the dropped resource will produce errors or
   inconsistent results

bz 578632

Signed-off-by: David Teigland <teigland(a)redhat.com&gt;
---
 group/gfs_controld/plock.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/group/gfs_controld/plock.c b/group/gfs_controld/plock.c
index a51a1fa..1b9120d 100644
--- a/group/gfs_controld/plock.c
+++ b/group/gfs_controld/plock.c
@@ -1215,6 +1215,8 @@ static void _receive_own(struct mountgroup *mg, char *buf, int len,
int from)
 	int should_not_happen = 0;
 	int rv;
 
+	mg->last_plock_time = time(NULL);
+
 	memcpy(&info, buf + sizeof(struct gdlm_header), sizeof(info));
 	info_bswap_in(&info);
 
@@ -1381,6 +1383,8 @@ static void _receive_sync(struct mountgroup *mg, char *buf, int len,
int from)
 	struct resource *r;
 	int rv;
 
+	mg->last_plock_time = time(NULL);
+
 	memcpy(&info, buf + sizeof(struct gdlm_header), sizeof(info));
 	info_bswap_in(&info);
 
@@ -1426,6 +1430,8 @@ static void _receive_drop(struct mountgroup *mg, char *buf, int len,
int from)
 	struct resource *r;
 	int rv;
 
+	mg->last_plock_time = time(NULL);
+
 	memcpy(&info, buf + sizeof(struct gdlm_header), sizeof(info));
 	info_bswap_in(&info);