[gfs2-utils] 01/02: Add basic unit tests for lgfs2_lookupi()

This is an automated email from the git hooks/post-receive script.

andyp pushed a commit to branch main
in repository gfs2-utils.

commit b72d50e98fd05572b45281f78a810681f06471b4
Author: Andrew Price <anprice(a)redhat.com&gt;
AuthorDate: Thu Mar 17 12:16:32 2022 +0000

    Add basic unit tests for lgfs2_lookupi()
    
    Signed-off-by: Andrew Price <anprice(a)redhat.com&gt;
---
 gfs2/libgfs2/check_fs_ops.c  | 132 +++++++++++++++++++++++++++++++++++++++++++
 gfs2/libgfs2/check_libgfs2.c |   2 +
 gfs2/libgfs2/checks.am       |   2 +-
 3 files changed, 135 insertions(+), 1 deletion(-)

diff --git a/gfs2/libgfs2/check_fs_ops.c b/gfs2/libgfs2/check_fs_ops.c
new file mode 100644
index 00000000..0b450ec1
--- /dev/null
+++ b/gfs2/libgfs2/check_fs_ops.c
@@ -0,0 +1,132 @@
+#include <stdlib.h>
+#include <unistd.h>
+#include <sys/types.h>
+#include <check.h>
+#include <errno.h>
+#include "libgfs2.h"
+
+Suite *suite_fs_ops(void);
+
+/* Doesn't need to be big, we just need some blocks to do i/o on */
+#define MOCK_DEV_SIZE (1 << 20)
+#define MOCK_BSIZE (512)
+
+struct lgfs2_sbd *mock_sdp;
+
+static void mockup_fs(void)
+{
+	struct lgfs2_sbd *sdp;
+	char tmpnam[] = "mockdev-XXXXXX";
+
+	sdp = calloc(1, sizeof(*sdp));
+	ck_assert(sdp != NULL);
+
+	sdp->device.length = MOCK_DEV_SIZE / MOCK_BSIZE;
+
+	sdp->device_fd = mkstemp(tmpnam);
+	ck_assert(sdp->device_fd >= 0);
+	ck_assert(unlink(tmpnam) == 0);
+	ck_assert(ftruncate(sdp->device_fd, MOCK_DEV_SIZE) == 0);
+
+	sdp->sd_bsize = MOCK_BSIZE;
+	lgfs2_compute_constants(sdp);
+
+	mock_sdp = sdp;
+}
+
+static void teardown_mock_fs(void)
+{
+	close(mock_sdp->device_fd);
+	free(mock_sdp);
+}
+
+START_TEST(test_lookupi_bad_name_size)
+{
+	struct lgfs2_inode idir;
+	struct lgfs2_inode *ret = NULL;
+	int e;
+
+	e = lgfs2_lookupi(&idir, ".", 0, &ret);
+	ck_assert(e == -ENAMETOOLONG);
+	ck_assert(ret == NULL);
+
+	e = lgfs2_lookupi(&idir, ".", GFS2_FNAMESIZE + 1, &ret);
+	ck_assert(e == -ENAMETOOLONG);
+	ck_assert(ret == NULL);
+}
+END_TEST
+
+START_TEST(test_lookupi_dot)
+{
+	struct lgfs2_inode idir;
+	struct lgfs2_inode *ret;
+	int e;
+
+	/* The contents of idir shouldn't matter, a "." lookup should just return
it */
+	e = lgfs2_lookupi(&idir, ".", 1, &ret);
+	ck_assert(e == 0);
+	ck_assert(ret == &idir);
+}
+END_TEST
+
+START_TEST(test_lookupi_dotdot)
+{
+	struct lgfs2_sbd *sdp = mock_sdp;
+	char buf[512] = {0};
+	struct lgfs2_buffer_head bh = {
+		.b_data = buf,
+		.b_blocknr = 42,
+	};
+	struct lgfs2_inode idir = {
+		.i_sbd = sdp,
+		.i_mode = S_IFDIR,
+		.i_bh = &bh,
+		.i_entries = 2,
+
+	};
+	struct gfs2_dirent *dent = (void *)(buf + sizeof(struct gfs2_dinode));
+	struct lgfs2_inode *ret;
+	int e;
+
+	/* "." */
+	dent->de_inum.no_addr = cpu_to_be64(42);
+	dent->de_inum.no_formal_ino = cpu_to_be64(1);
+	dent->de_rec_len = cpu_to_be16(GFS2_DIRENT_SIZE(1));
+	dent->de_name_len = cpu_to_be16(1);
+	dent->de_hash = cpu_to_be32(lgfs2_disk_hash(".", 1));
+	*(char *)(dent + 1) = '.';
+
+	/* ".." */
+	dent = (void *)(buf + sizeof(struct gfs2_dinode) + GFS2_DIRENT_SIZE(1));
+	dent->de_inum.no_addr = cpu_to_be64(43);
+	dent->de_inum.no_formal_ino = cpu_to_be64(2);
+	dent->de_rec_len = cpu_to_be16(MOCK_BSIZE - GFS2_DIRENT_SIZE(1) - sizeof(struct
gfs2_dinode));
+	dent->de_name_len = cpu_to_be16(2);
+	dent->de_hash = cpu_to_be32(lgfs2_disk_hash("..", 2));
+	*(char *)(dent + 1) = '.';
+	*((char *)(dent + 1) + 1) = '.';
+
+	e = lgfs2_lookupi(&idir, "..", 2, &ret);
+	ck_assert(e == 0);
+	ck_assert(ret != &idir);
+	lgfs2_inode_put(&ret);
+}
+END_TEST
+
+Suite *suite_fs_ops(void)
+{
+	Suite *s = suite_create("fs_ops.c");
+	TCase *tc;
+
+	tc = tcase_create("lgfs2_lookupi basic");
+	tcase_add_test(tc, test_lookupi_bad_name_size);
+	tcase_add_test(tc, test_lookupi_dot);
+	suite_add_tcase(s, tc);
+
+	tc = tcase_create("lgfs2_lookupi with fixture");
+	tcase_add_checked_fixture(tc, mockup_fs, teardown_mock_fs);
+	tcase_add_test(tc, test_lookupi_dotdot);
+	suite_add_tcase(s, tc);
+
+	return s;
+}
diff --git a/gfs2/libgfs2/check_libgfs2.c b/gfs2/libgfs2/check_libgfs2.c
index 2ee5895d..b78eecfa 100644
--- a/gfs2/libgfs2/check_libgfs2.c
+++ b/gfs2/libgfs2/check_libgfs2.c
@@ -4,6 +4,7 @@
 extern Suite *suite_meta(void);
 extern Suite *suite_ondisk(void);
 extern Suite *suite_rgrp(void);
+extern Suite *suite_fs_ops(void);
 
 int main(void)
 {
@@ -12,6 +13,7 @@ int main(void)
 	SRunner *runner = srunner_create(suite_meta());
 	srunner_add_suite(runner, suite_ondisk());
 	srunner_add_suite(runner, suite_rgrp());
+	srunner_add_suite(runner, suite_fs_ops());
 
 	srunner_run_all(runner, CK_ENV);
 	failures = srunner_ntests_failed(runner);
diff --git a/gfs2/libgfs2/checks.am b/gfs2/libgfs2/checks.am
index d1aa7189..d1afca55 100644
--- a/gfs2/libgfs2/checks.am
+++ b/gfs2/libgfs2/checks.am
@@ -10,7 +10,7 @@ check_libgfs2_SOURCES = \
 	ondisk.c check_ondisk.c \
 	buf.c \
 	device_geometry.c \
-	fs_ops.c \
+	fs_ops.c check_fs_ops.c \
 	structures.c \
 	fs_bits.c \
 	gfs1.c \

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.