Gitweb:
http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=...
Commit: 51e9b45f109b1678413228f3654de55cb935ed90
Parent: e9277676d10b511efee18342b60088bfd85e0ba9
Author: Lon Hohberger <lhh(a)redhat.com>
AuthorDate: Fri Jun 19 22:59:53 2009 -0400
Committer: Lon Hohberger <lhh(a)redhat.com>
CommitterDate: Mon Sep 28 11:33:55 2009 -0400
rgmanager: Fix small memory leak
Resolves: bz507431
Signed-off-by: Lon Hohberger <lhh(a)redhat.com>
---
rgmanager/src/daemons/slang_event.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c
index c3c337c..b3273ac 100644
--- a/rgmanager/src/daemons/slang_event.c
+++ b/rgmanager/src/daemons/slang_event.c
@@ -440,16 +440,23 @@ out:
/**
get_service_property(service_name, property)
*/
-char *
+static void
sl_service_property(char *svcName, char *prop)
{
char buf[96];
+ char *ret;
if (get_service_property(svcName, prop, buf, sizeof(buf)) < 0)
- return NULL;
+ return;
/* does this work or do I have to push a malloce'd string? */
- return strdup(buf);
+ ret = strdup(buf);
+ if (SLang_push_malloced_string(ret) < 0) {
+ SLang_verror(SL_RunTime_Error,
+ (char *)"%s: Failed to push %s property of %s",
+ __FUNCTION__, prop, svcName);
+ free(ret);
+ }
}