Gitweb:
http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=...
Commit: 0500b5311a809ea119599488374ef094b633f1d5
Parent: 51e9b45f109b1678413228f3654de55cb935ed90
Author: Lon Hohberger <lhh(a)redhat.com>
AuthorDate: Mon Jun 22 14:14:53 2009 -0400
Committer: Lon Hohberger <lhh(a)redhat.com>
CommitterDate: Mon Sep 28 11:34:41 2009 -0400
rgmanager: Don't push NULL on to the S/Lang stack
Resolves: bz507431
Signed-off-by: Lon Hohberger <lhh(a)redhat.com>
---
rgmanager/src/daemons/slang_event.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c
index b3273ac..a9b69ab 100644
--- a/rgmanager/src/daemons/slang_event.c
+++ b/rgmanager/src/daemons/slang_event.c
@@ -449,8 +449,15 @@ sl_service_property(char *svcName, char *prop)
if (get_service_property(svcName, prop, buf, sizeof(buf)) < 0)
return;
- /* does this work or do I have to push a malloce'd string? */
ret = strdup(buf);
+ if (!ret) {
+ SLang_verror(SL_RunTime_Error,
+ (char *)"%s: Failed to duplicate state of %s",
+ __FUNCTION__,
+ svcName);
+ return;
+ }
+
if (SLang_push_malloced_string(ret) < 0) {
SLang_verror(SL_RunTime_Error,
(char *)"%s: Failed to push %s property of %s",