Re: [Crash-catcher] [PATCH] new bugzilla reporter
On Tue, 2010-02-09 at 13:46 +0100, Nikola Pajkovsky wrote:
Dne 8.2.2010 19:37, Denys Vlasenko napsal(a):
> Hi,
>
> This is the review of Nikola's new bz code.
>
>
>
>> static int32_t abrt_errno;
>>
My idea is rid of all try and catch mechanism and replace it with our
errno mechanism.
> This should be a member of "struct ctx" and it should be just
"int"
>
What do you have against int32_t?
Because int32_t is a type with explicit bit width.
It is supposed to be used only when you _have to_ have an exactly
32-bit wide variable.
OTOH int type is an "integer of natural size for this architecture".
20 years from now, on most machines "int" will probably be 64-bit
and people would wonder "why abrt_errno is int32_t? there must be
some special reason for that...". But there is not.
--
vda