Re: [PATCH 5/7] remove useless bracket
On 08/27/2010 05:46 PM, Denys Vlasenko wrote:
On Fri, 2010-08-27 at 17:05 +0200, Nikola Pajkovsky wrote:
> Signed-off-by: Nikola Pajkovsky<npajkovs(a)redhat.com>
> ---
> src/applet/Applet.cpp | 5 +----
> src/applet/CCApplet.cpp | 10 ++++------
> 2 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/src/applet/Applet.cpp b/src/applet/Applet.cpp
> index b00ae5f..f347592 100644
> --- a/src/applet/Applet.cpp
> +++ b/src/applet/Applet.cpp
> @@ -56,9 +56,8 @@ static void Crash(DBusMessage* signal)
> /* Optional 3rd param: uid */
> const char* uid_str = NULL;
> if (r == ABRT_DBUS_MORE_FIELDS)
> - {
> r = load_val(&in_iter, uid_str);
> - }
> +
And when someone will need to add a second statement in the if() body,
he will need to add them again. I think bracket removal is not needed.
IMO, when they are added, they should stay.
(I personally like less wasteful style with one less line consumed:
if (expr) {
cmd;
}
When I read more and more git source code, I'm starting more and more like
this notations, but I ready don't like use it for one cmd.
which makes added {}'s eat only one line, not two,
but alas I am in minority here ;[ )
I tend to NAK this patch.