On 5/31/19 5:51 PM, Florian Weimer wrote:
* Carlos O'Donell:
> On 5/31/19 5:32 PM, DJ Delorie wrote:
>>
>> "Carlos O'Donell" <carlos(a)redhat.com> writes:
>>> +remove_regexps = {}
>>> +for i = 1, #install_libs do
>>> + remove_regexps[i] = ("lib" .. install_libs[i]
>>> + .. "%%-[2-9][0-9]*%%.[0-9]+%%.so$")
>>> +end
>>
>> Won't match libc-10.1 but let's worry about that later :-)
>>
>
> -- We employ a tight match where X.Y is in [2.0,9.9*], so we would
> -- match "libc-2.0.so" and so on up to "libc-9.9*".
>
> Fixed.
Did you change the regexp as well? Dropping the [0-9]*?
No, but I see your point, the current expression obviously supports
more than that, and so the comment is inaccurate.
It's not useful to have '[0-9]*' following the [2-9] since we'll
never get that high in any reasonable long-term timeline.
I'll drop the '[0-9]*' and commit that with the above comment.
Testing looks good.
I've pushed the glibc_post_upgrade conversion to lua. With your
recent removal of build-locale-archive, we've killed two statically
compiled binaries in one step and made things simpler.
--
Cheers,
Carlos.