[Bug 708473] Review Request: mingw32-cxxtest - cxxtest for mingw32
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708473
--- Comment #12 from Adam Stokes <astokes(a)redhat.com> 2011-07-21 10:47:37 EDT ---
(In reply to comment #9)
> I'm re-opening this review ticket as I don't agree with the 'review' which was
> done here. The .spec file which is attached here doesn't even build in mock!
> The .spec file which was imported in rawhide is in a bit better shape, but
> still not compliant with the general Fedora packaging guidelines and the
> MinGW-specific packaging guidelines:
> http://fedoraproject.org/wiki/Packaging:MinGW
>
> I'll do a proper review now based on what's now in rawhide (3.10.1-4.fc16).
>
> The Source0 and Source1 URL's are invalid:
> $ spectool -g mingw32-cxxtest.spec
> Getting
> http://cxxtest.tigris.org/files/documents/6421/43281/mingw32-cxxtest-3.10...
> to ./mingw32-cxxtest-3.10.1.tar.gz
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
> curl: (22) The requested URL returned error: 404
> Getting
> http://cxxtest.tigris.org/files/documents/6421/43284/mingw32-cxxtest-guid...
> to ./mingw32-cxxtest-guide-3.10.1.pdf
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
> curl: (22) The requested URL returned error: 404
>
> Please use working URLs or add a comment how the .tar.gz can be regenerated
>
> As your only targeting F-15 and rawhide, several things can be dropped from the
> .spec file like the BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' from the
> %install phase, the entire %clean section and the %defattr lines from both
> subpackages. The conditionals for fedora < 11 and rhel can also be dropped as
> they're unneeded when you only target F-15 and rawhide.
>
> Why are you bundling the python pieces with this package? We don't have python
> support in the MinGW toolchain in Fedora so the python pieces are kinda
> useless. The python code and the -doc subpackage are also bundled with the
> native Fedora cxxtest package so they can both the dropped from the mingw
> package.
>
> Is it correct that this package only provides some C++ header files? If that's
> the case then the two %global overrides can be dropped as they only apply to
> mingw binaries. Do note however that when this package starts to bundle
> binaries that several overrides need to be added (for dependency and debuginfo
> extraction). See the Fedora MinGW packaging guidelines for an example.
>
> If you aren't bundling any mingw binaries then you need add to a Requires:
> mingw32-filesystem manually.
>
> Why was this package imported as mingw32-cxxtest? The current Fedora MinGW
> guidelines strongly suggest to name new packages mingw-, so that in the future
> it would be easier to build mingw64- binary packages. Now that you've used
> mingw32- source package naming, you'll have to retire mingw32-cxxtest and
> re-review mingw-cxxtest once the mingw64 compiler is ready, probably in the F17
> timeframe
Just for my benefit what happens to the existing mingw32 packages that are
already in the distro? Will we be doing a mass rename of these when the
compiler is ready?
Thanks
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years, 10 months
[Bug 708473] Review Request: mingw32-cxxtest - cxxtest for mingw32
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708473
--- Comment #11 from Adam Stokes <astokes(a)redhat.com> 2011-07-21 10:33:51 EDT ---
(In reply to comment #10)
> Created attachment 514160 [details]
> Patch to address issues pointed out by Erik
>
> Adam and Roman: To help you guys out, I am attaching a patch which should
> hopefully address all the issues pointed out by Erik.
Very awesome, thank you so much. I'll run some quick tests and post an updated
package.
Thanks again
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years, 10 months
[ACTION REQUIRED] Retiring packages in F-16 (final warning)
by Kalev Lember
Hi,
Erik mentioned yesterday on IRC that mingw32-physfs is going to be
retired unless someone picks it up; I'm forwarding the mail here just in
case someone is interested.
On 07/20/2011 10:28 PM, Bill Nottingham wrote:
> Each release, before branching, we block currently orphaned packages.
> It's that time again for Fedora 16.
>
> New this go-round is that we are also blocking packages that have
> failed to build since before Fedora 14.
>
> The following packages are currently orphaned, or fail to build. If
> you have a need for one of these packages, please pick them up.
>
> If not claimed, the packages will be blocked on Monday, July 25.
>
[snip]
> Orphan mingw32-physfs
> comaintained by: rjones
12 years, 10 months
[mingw32-libjpeg] Package has been replaced by mingw-libjpeg-turbo
by Erik van Pienbroek
commit 3d27291e183dafe94e2f566bdc4ce6fc5850999e
Author: Erik van Pienbroek <epienbro(a)fedoraproject.org>
Date: Thu Jul 21 01:47:54 2011 +0200
Package has been replaced by mingw-libjpeg-turbo
dead.package | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/dead.package b/dead.package
index f2396d2..32bc236 100644
--- a/dead.package
+++ b/dead.package
@@ -1 +1 @@
-Package is retired
\ No newline at end of file
+Package is retired, replaced by mingw-libjpeg-turbo
12 years, 10 months
[mingw32-libjpeg] Package is retired
by Erik van Pienbroek
commit 67032572916051237614ba908c5baedb1784bd8e
Author: Erik van Pienbroek <epienbro(a)fedoraproject.org>
Date: Thu Jul 21 01:46:08 2011 +0200
Package is retired
.gitignore | 1 -
configure.in | 346 ------
dead.package | 1 +
jpeg-fix-typo.patch | 11 -
jpeg-mingw32.patch | 12 -
jpeg-workaround-typedef-conflict.patch | 1877 --------------------------------
libjpeg-autoconf.patch | 30 -
libjpeg-buf-oflo.patch | 25 -
libjpeg-cflags.patch | 20 -
mingw32-libjpeg.spec | 174 ---
sources | 1 -
11 files changed, 1 insertions(+), 2497 deletions(-)
---
diff --git a/dead.package b/dead.package
new file mode 100644
index 0000000..f2396d2
--- /dev/null
+++ b/dead.package
@@ -0,0 +1 @@
+Package is retired
\ No newline at end of file
12 years, 10 months