Re: filesystem patch?
Richard W.M. Jones wrote:
On Sun, Nov 30, 2008 at 06:18:36PM +0100, Farkas Levente wrote:
> Richard W.M. Jones wrote:
>> On Sun, Nov 30, 2008 at 12:27:15AM +0100, Farkas Levente wrote:
>>> hi,
>>> did you review my past filesystem patch?
>> OK, I'll have a look at it tomorrow^Wtoday .. Can you repost what you
>> think is the latest version so we are on the same page?
> here it's again.
>
>> Thanks for taking a look at those other reviews.
> the other patch in the libxml2 what we already discuss in the review:
> --- mingw32-libxml2.spec.lfarkas 2008-11-10 18:03:16.000000000 +0100
> +++ mingw32-libxml2.spec 2008-11-10 18:35:10.000000000 +0100
> @@ -40,6 +40,10 @@
>
>
> %build
> +%if 0%{?fedora} < 9
> +aclocal
> +autoreconf
> +%endif
Am I right in thinking that this code only applies for Fedora <= 8 (or
does that include EPEL?) Anyway, yes the patch is fine, because it
won't affect us, but it will break things in mock/F-8 because you also
need to add a BuildRequires: autoconf, automake, libtool (or something
like that).
actually it's effect epel too, what's more that's the reason why i use
it. rhel-5's rpm sp old it doesn't have any define to recognize the
distro, so this is the easiest way to do so. and as libxm2's tarbal was
generated with newer autoconf the epel versuin can't use it so we've to
regenerate them. and you've got right BR should have to be also added
into the same %if block.
> Index: mingw32-filesystem.spec
> ===================================================================
> RCS file: /cvs/pkgs/rpms/mingw32-filesystem/devel/mingw32-filesystem.spec,v
> retrieving revision 1.6
> diff -u -u -r1.6 mingw32-filesystem.spec
> --- mingw32-filesystem.spec 24 Nov 2008 16:08:07 -0000 1.6
> +++ mingw32-filesystem.spec 27 Nov 2008 20:54:54 -0000
I have some time to look at this tomorrow. If it works I'll just
apply it.
thanks.
--
Levente "Si vis pacem para bellum!"