update publictest16 (all links now have static versions for opening in a new window)

[John (J5) Palmieri]

In order to make this work you need to tag any link in a mako template (or even static
html pages) you wish to be transformed with moksha_url="<dynamic|static>".
 "static" simply rewrites the href to include the csrf token and any other query
string variables that are set.  "dynamic" does the static rewrite but also sets
up an onClick handler so that the csrf token and query string can be updated when the user
clicks and not just when the page load.  It will also in the future try to determine if a
whole page load is unnecessary and simply switch tabs if that is the case.  

The only place where you do not add moksha_url is inside of the javascript grid templates
since it transforms the template, messing up the final output.  The grid will take care of
the template links.  Come to think of it I still want you to be able to add the markers to
the grid template so I am going to look at a way to tell the parser to ignore anything
inside javascript templates.  For now just assume all links will be transformed to a
dynamic url.
 
--
John (J5) Palmieri
Software Engineer
Red Hat, Inc.

[Tom Callaway]

On 04/29/2009 05:52 PM, John Palmieri wrote:
>  In order to make this work you need to tag any link in a mako
> template (or even static html pages) you wish to be transformed with
> moksha_url="<dynamic|static>".  "static" simply rewrites the
> href to include the csrf token and any other query string variables that are set. 
> "dynamic" does the static rewrite but also sets up an onClick handler so that
> the csrf token and query string can be updated when the user clicks and not just when the
> page load.  It will also in the future try to determine if a whole page load is
> unnecessary and simply switch tabs if that is the case.  
>  
>  The only place where you do not add moksha_url is inside of the javascript grid templates
> since it transforms the template, messing up the final output.  The grid will take care of
> the template links.  Come to think of it I still want you to be able to add the markers to
> the grid template so I am going to look at a way to tell the parser to ignore anything
> inside javascript templates.  For now just assume all links will be transformed to a
> dynamic url. 
Good work J5! We're really cooking with gas now! :)

~spot

[Luke Macken]

On Wed, Apr 29, 2009 at 05:52:51PM -0400, John Palmieri wrote:
>  In order to make this work you need to tag any link in a mako
> template (or even static html pages) you wish to be transformed with
> moksha_url="<dynamic|static>".  "static" simply rewrites the
> href to include the csrf token and any other query string variables that are set. 
> "dynamic" does the static rewrite but also sets up an onClick handler so that
> the csrf token and query string can be updated when the user clicks and not just when the
> page load.  It will also in the future try to determine if a whole page load is
> unnecessary and simply switch tabs if that is the case.  
>  
>  The only place where you do not add moksha_url is inside of the javascript grid templates
> since it transforms the template, messing up the final output.  The grid will take care of
> the template links.  Come to think of it I still want you to be able to add the markers to
> the grid template so I am going to look at a way to tell the parser to ignore anything
> inside javascript templates.  For now just assume all links will be transformed to a
> dynamic url. 
Nice work!  We need to make sure that this is well-documented as well.

luke

[John (J5) Palmieri]

----- "John Palmieri" <johnp(a)redhat.com&gt; wrote:


>  The only place where you do not add moksha_url is inside of the
>  javascript grid templates since it transforms the template, messing up
>  the final output.  The grid will take care of the template links. 
>  Come to think of it I still want you to be able to add the markers to
>  the grid template so I am going to look at a way to tell the parser to
>  ignore anything inside javascript templates.  For now just assume all
>  links will be transformed to a dynamic url. 
It bothered me enough that I fixed this.  You now need to mark links inside of javascript
templates too.  Any marked links
with an ancestor of class "rowtemplate" or "template" will be ignored
on first pass.  It is up to the code using the template
(right now just the grid) to run moksha.update_marked_anchors or the rendered template
fragment.

--
John (J5) Palmieri
Software Engineer
Red Hat, Inc.