On 10/30/2014 10:09 AM, Laine Stump wrote:
(another case of explanation taking longer than the patch...)
This resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1147650
The solution to this is to improve the *-put.xsl to recognize either
the old form *or* the ${var}0 form when converting into <interface>
XML. For maximum compatibility, the conversion back into ifcfg format
is left the same, as all versions of initscripts and NetworkManager
that I've tried continue to recognize them.
Beyond what is done here, both NM and initscripts recognize IPADDRn
where "n" can be any number up to 255, and since we support multiple
IPv6 addresses in netcf, I would like to support multiple IPv4
addresses as well. That is left for a future patch, as my XSL skills
simply are not up to that task (patches welcome!)
---
data/xml/redhat-put.xsl | 61 +++++++++++++++++++++++++++++++++++++------------
data/xml/suse-put.xsl | 61 +++++++++++++++++++++++++++++++++++++------------
2 files changed, 94 insertions(+), 28 deletions(-)
I'm no xsl expert, but this patch makes sense to me, so weak ACK.
I'm still hoping DV can help you with the goal of parameterizing it to
cover all the way to IPADDR256 without a 256-way <xsl:choose>, but that
trick is beyond my knowledge at the moment.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org