On 10/23/2009 12:32 PM, Daniel P. Berrange wrote:
On Fri, Oct 23, 2009 at 10:34:54AM -0400, Laine Stump wrote:
> A couple of questions on this topic:
>
> 1) I didn't add anything to ncftool that exercises this new
> functionality. Do you see any use to this? (The information is given
> implicitly by "list").
>
It could be useful to include it in the list output, eg
instead of
ncftool> list --all
eth0
eth1
lo
ppp0
have
ncftool> list --all
eth0 UP
eth1 UP
lo UP
ppp0 DOWN
or some less crude formatting
Okay, I'll take a whack at that momentarily.
I'm also adding in reporting of mac address, which will hopefully work
as easily as it seems to be getting written...
> 2) Would it be useful to also add this information to the xml of
> ncf_if_xml_state()? If so, any suggestions on what it should look like?
>
I don't think it is relevant there, because whether an interface is up
or down is not configuration information.
ncf_if_xml_desc() is the config, ncf_if_xml_state() is only the
information we got directly from the kernel.