On Mon, Aug 24, 2020 at 10:22 AM Fernando Fernandez Mancera
<ferferna(a)redhat.com> wrote:
On Mon, Aug 24, 2020 at 9:58 AM Till Maas <till(a)redhat.com> wrote:
>
> Hi,
>
> Am Do., 13. Aug. 2020 um 17:06 Uhr schrieb Gris Ge <fge(a)redhat.com>:
> >
> > Hi,
> >
> > I would like to suggest we deprecate our use of `master/slave` in
> > nmstate project.
> >
> > And switching to these terminologies for interface relationship in
> > the coming new release of nmstate-0.4.0:
> >
> > * For bond/team/bridge:
> > * controller/subordinate
> > # For bridge, we can also use controller/port.
>
> having shorter words would be nice, maybe
>
> trunk/leg
> base/leg
>
> base/dell
> mesa/dell
> base/vale
>
> bulk/part
>
> >
> > * For VLAN/VxLAN:
> > * parent/child
> > * base/child
> > # Current API using `base-iface`, no need to change
>
> Some other suggestions:
> base/apex
> mesa/apex
>
> base/head
> trunk/head
Those are a little bit confusing for me. I expect both "base" and
"head" would replace "master".
I also find some (most?) of those confusing. I'm not a native speaker
- which might explain why - but terms like 'mesa' / 'dell' /
'vale'
are unknown to me.
I've been thinking on this and it would be good to use only one option
for codebase, i.e using the same terms for all kind of interfaces. For
the exposed API, I would not change VLAN/VXLAN as we are already using
base/child terms. For other interfaces I noticed that we are mixing up
"slaves" and "ports", I suggest to unify it into a generic one. IMO,
the most generic are "controller/subordinate".
If we agree on the generic word, I would use them for the whole codebase.
+ 1 on this; the simpler the better. Now, coming up with a generic
word that makes sense across all the interfaces types will not be
easy.
What do you think? Thanks!
I know I'm not adding much to the discussion, but I'd like to voice
what I expect as a user of the API.
>
>
> The trunk interface of eth1 is bond0
> eth1 is a leg of the bridge br0
> eth1 is a leg of an base interface
> eth1 is a dell interface of br0 (probably not so nice because of the
> confusion with the manufacturer)
> eth1 is a vale interface of br0
> eth1 is a limb of br0
> eth1 is a leg of br0
> br0 is the trunk for eth1
>
>
> eth1 is a part interface of the br0 bulk interface
>
>
> the base of VLAN eth1.100 is eth1
> eth1.100 is an apex interface of eth1
> eth1.100 is a head of eth1
> eth1 is the trunk interface for eth1.100.
> eth1 is the base interface for eth1.100.
> eth1 is the trunk for eth1.100
> eth1.100 is a limb of eth1
> eth1.100 is an arm of eth1
>
>
> These seem to be my current favorites:
> leg/trunk/head
> limb/trunk/limb
>
> Limb could be used both for the interfaces included in a bridge or a
> bond. Not sure, if they need to have different identifiers.
>
>
> >
> > For example:
> > * The `controller` of eth1 is bond0 and `controller_type` is bond
> > * The br0 is `controller` of eth1
> > * The eth1 is `port` of bridge br0 or `subordinate` of bridge br0
> > * The eth1 is `subordinate` of bond0
> > * The VLAN eth1.100 is child of eth1
> > * The base interface of eth1.100 is eth1
> > * The parent of VLAN eth1.100 is eth1
> > * The VLAN eth1.100 is child of eth1
> >
> > I am not English native speaker, please kindly help on this if you have
> > better ideas.
> >
> > Thank you very much!
>
> Thank you for moving this forward!
>
> Till
>
>
>
> --
> Till Maas
> He/His/Him
> Associate Manager, Software Engineering
> NetworkManager, Nmstate, Ansible RHEL Networking System Role
>
> Red Hat GmbH,
http://www.de.redhat.com/, Registered seat: Grasbrunn,
> Commercial register: Amtsgericht Muenchen, HRB 153243,
> Managing Directors: Charles Cachera, Laurie Krebs, Michael O'Neill,
> Thomas Savage
>
_______________________________________________
nmstate-devel mailing list -- nmstate-devel(a)lists.fedorahosted.org
To unsubscribe send an email to nmstate-devel-leave(a)lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/nmstate-devel@lists.fedoraho...