Review Request 151: Hardware: Code clean up
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/151/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Code clean up
* Got rid of asprintf() where suitable (used static memory instead)
* Removed if condition before free()
* Replaced more hard coded numbers with LMI constants
Diffs
-----
src/hardware/LMI_ProcessorCacheMemoryProvider.c d4c73f65bee82e26b8b09a9f5ed3bc22945d762a
src/hardware/LMI_Hardware.h 16bdf122e2f5b611b45c7a508726b3a09808c8d4
src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c b06aa223d4e954d51abf2431c3a0a6247283b648
src/hardware/LMI_ProcessorCapabilitiesProvider.c c7c4ff250d89e2c115cbbda8a54845213fccb770
src/hardware/LMI_ProcessorElementCapabilitiesProvider.c ee9cf18a33f2ebe3784b8e5c53c6e28769b1871f
src/hardware/LMI_ProcessorProvider.c 6280bbd60d732433870ebc539146006daf2fa126
src/hardware/cpuinfo.c d80e1cb5890cd1c72fff7c257cb4f042dd50b06d
src/hardware/dmidecode.c a50aa8a19ae0fc3acc6979484cdff2dc1cdff0a9
src/hardware/lscpu.c d4546cb42a401c4b6d79bc9e13990d94c463d282
src/hardware/sysfs.c c2cc1affeabf0329ca32e1d9956eaf468b0a56d1
src/hardware/utils.h 9f5686faf4e50775b18adb62bfd0f5a707f093cb
src/hardware/utils.c da7bbfadffd77afd5ecc1c81360cb7f23f3412e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/151/diff/
Testing
-------
Thanks,
Peter Schiffer
11 years, 2 months
Review Request 146: Fixed traceback in EnumerateInstances on LMI_LocalFileSystem.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/146/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Fixed traceback in EnumerateInstances on LMI_LocalFileSystem.
CIM_ERR_FAILED: Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/cmpi_pywbem_bindings.py", line 82, in __call__
return self.meth(*args, **kwds)
File "/usr/lib/python2.7/site-packages/cmpi_pywbem_bindings.py", line 487, in enum_instances
for i in self.proxy.MI_enumInstances(env, op, plist):
File "/usr/lib/python2.7/site-packages/openlmi/storage/FormatProvider.py", line 144, in enum_instances
yield self.get_instance(env, model, fmt)
File "/usr/lib/python2.7/site-packages/openlmi/common/cmpi_logging.py", line 81, in helper_func
ret = func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/openlmi/storage/LocalFileSystemProvider.py", line 321, in get_instance
uuid = self.get_uuid(device, fmt)
UnboundLocalError: local variable 'device' referenced before assignment
Diffs
-----
src/openlmi/storage/LocalFileSystemProvider.py ca8478dbe833e2df34c16ecc5e6df74aa01b3774
Diff: http://reviewboard-openlmi.rhcloud.com/r/146/diff/
Testing
-------
Thanks,
Jan Safranek
11 years, 2 months
Review Request 144: Fixed job expiration under SFCB.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/144/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Fixed job expiration under SFCB.
SFCB does not allow logging in not-registered threads, therefore
we must not log in job's Timer thread, i.e. Job._expire method.
Jobs now expire silently, without any logging, I have bad feelings about it.
Diffs
-----
src/openlmi/storage/JobManager.py e182c16e98a51d0fad3e032895d1103cf333ff64
Diff: http://reviewboard-openlmi.rhcloud.com/r/144/diff/
Testing
-------
Thanks,
Jan Safranek
11 years, 2 months
Review Request 143: Doc [4/4]: Rename documentation files to follow new chapter structure.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/143/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Rename documentation files to follow new chapter structure.
Diffs
-----
doc/admin/concept.rst PRE-CREATION
doc/admin/index.rst 37f8a50f79872bae68f0a1e66303818dabc37d71
doc/admin/usage-conventions.rst
doc/admin/usage-devices.rst 34d8aea8784acd15223e0c0e448237ff70c3ee5e
doc/admin/usage-generic.rst 01f6c7aee1a69e1c55c2c5af009354882249728f
doc/admin/usage-job.rst
doc/admin/usage-manipulate.rst PRE-CREATION
doc/admin/usage-overwrite.rst PRE-CREATION
doc/admin/usage.rst 694557a373d0cbb84888756766b884467b4a98ae
Diff: http://reviewboard-openlmi.rhcloud.com/r/143/diff/
Testing
-------
Thanks,
Jan Safranek
11 years, 2 months
Review Request 142: Doc [3/4]: Reorganize the documentation.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/142/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Reorganize the documentation.
Some headings are renamed, there are no content changes. The goal is having
one 'OpenLMI-Storage usage' chapter with subchapter for every device type
(LVM, RAID, partitioning).
Diffs
-----
doc/admin/index.rst 37f8a50f79872bae68f0a1e66303818dabc37d71
doc/admin/usage-generic.rst 01f6c7aee1a69e1c55c2c5af009354882249728f
doc/admin/usage-manipulate.rst PRE-CREATION
doc/admin/usage.rst 694557a373d0cbb84888756766b884467b4a98ae
Diff: http://reviewboard-openlmi.rhcloud.com/r/142/diff/
Testing
-------
Thanks,
Jan Safranek
11 years, 2 months
Review Request 140: Doc [1/4]: Added documentation of the new Delete... methods.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/140/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Doc [1/4]: Added documentation of the new Delete... methods.
Diffs
-----
doc/admin/usage-devices.rst 34d8aea8784acd15223e0c0e448237ff70c3ee5e
doc/admin/usage-fs.rst 2c85856c12b14c889e1831fc7b46c6562de5d44d
doc/admin/usage-lvm.rst 20a5383812ba83be6869edb3f50654f02446b6de
doc/admin/usage-partitioning.rst 47ae0cde84bce82a4d601cf07c34bf59b55da6ae
doc/admin/usage-raid.rst 72aa07363624c5f0fa867da22fd3eaf9f164f417
Diff: http://reviewboard-openlmi.rhcloud.com/r/140/diff/
Testing
-------
Thanks,
Jan Safranek
11 years, 2 months
proposal for naming of mof files
by Michal Minář
Hello,
I'd like to propose a simple change to naming our mof files to make
their installation more reliable. There is a small shortcoming in sfcb
mof registration scripts. They are parsed only once sorted by their
name. If there occurs one class/instance or any other object in this
compilation process, that does not have some of its dependencies (like
parent class or property qualifier) already compiled, the compilation stops.
Consider the following example:
* LMI_Qualifiers.mof - defines Implemented qualifier used by mof files
of at least storage and software profiles.
* LMI_Jobs.mof - defines base classes for asynchronous job management
supposed to be inherited by other classes of particular profile. It
uses Implemented qualifier. Therefore it depends on LMI_Qualifiers.mof.
* LMI_Software.mof- the one and only mof file of software profile.
Also uses Implemented qualifier and moreover it inherits some
classes from LMI_Jobs.mof.
o Therefore it depends on both LMI_Qualifiers.mof and LMI_Jobs.mof.
If we sort these mof files by name we get: LMI_Jobs.mof,
LMI_Software.mof, LMI_Qualifiers.mof.
Upon invocation of
$ sfcbrepos -f
We get a lot of errors like this one:
error in /var/lib/sfcb/stage/mofs/root/cimv2/LMI_Software.mof line
106 near true: Implemented is not a known qualifier
Because Implemented would come as last - a lot later, than it is needed.
If LMI_Software.mof had a name LMI_Applications.mof instead, it would
miss definitions from two files and so on.
*Note* that this is only problem of sfcb cimom, pegasus is smarter.
I searched for a way to avoid this and found out, that even sfcb's own
mof files located in
/var/lib/sfcb/stage/mofs/root/interop
are named with pattern *NN_name.mof*, where *NN* are digits ensuring
corrent order of files upon
compilation.
I guess, that we will share more common definitions across our providers
in the near future. So I think, that it would be desirable to establish
a convention for naming mof files, that would ensure their correct
installation in "not so smart" cimoms. And we should do it soon.
My proposal is: let's do it like sfcb:
*NN_LMI_ProfileName.mof
*
And let's also specify some advisable numbers. For example:
* 05 - 10 - qualifiers and other simple mofs without any dependencies
on LMI or anything outside of cim-schema (05_LMI_Qualifiers.mof).
These will be shipped with openlmi-providers.
* 20 - 40 - mofs with base classes for our providers
(30_LMI_Jobs.mof). Also shipped with openlmi-providers.
* 50 - 80 - mofs of our profiles shipped in their own package
(60_LMI_Software.mof).
This is a request for comments. Please share your own ideas on how to
solve this issue.
Michal Minar
11 years, 2 months
CIM Provider HOWTO Document
by John Dennis
[ Note: some of you may receive a duplicate of this email, sorry.
This time the PDF is linked to instead of attached. ]
When I started development of the realmd CIM provider I was told I was
being a guinea pig. Take a developer who knows nothing about CIM or
OpenLMI and see what issues a novice might encounter when asked to write
a CIM provider. Then use that experience to write up documentation to
pave the way for other developers to follow.
When I first started a few months ago the material on the OpenLMI wiki
was sparse. I see that it has since been enhanced.
Here is a 24 page PDF. It is what I would have liked to have started
with as a developer.
http://jdennis.fedorapeople.org/cim-provider-howto.pdf
The content is written in pandoc format, a universal format that can be
formatted into HTML, PDF, mediawiki, reStructuredText, and many other
document formats. As such this content can be put up on the web easily.
I'm distributing this initial draft as a PDF because in my opinion the
PDF formatting yields the most readable presentation. The document
contains many clickable links to other material.
Those of you in the OpenLMI group will no doubt have corrections and
suggestions on the technical content which I welcome, I'm sure as a
neophyte I've made some errors along the way. Others may want to add
their own suggestions and comments.
It's been an interesting ride. I hope this serves as a good foundation
to build upon.
John
--
John Dennis <jdennis(a)redhat.com>
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
11 years, 2 months