April 2013 - openlmi-devel - Fedora Mailing-Lists

Review Request 100: Build System [2/2] Enable building openlmi-tools with setuptools

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/100/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-tools Description ------- The openlmi-tools are built entirely in Python. It seems wasteful to use the heavyweight autotools build system for it. This patch and the one in review https://reviewboard-openlmi.rhcloud.com/r/99/ will replace the autotools build system with one based on Python's setuptools. Apologies for the ugly in-browser diff. Apparently, ReviewBoard does not handle file moves very gracefully yet. I've attached a different version of the diff as well, which only shows that a move happens and then the differences made. It's easier to spot that way. Diffs ----- cli-tools/lmi/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 cli-tools/lmi/lmi_address.py 140dd269fef10350500c1e3fb0579ef2a46d4063 cli-tools/lmi/lmi_client_base.py a69cdfef704e34f8761eecbaa52497920935a6bb cli-tools/lmi/lmi_client_ip.py c5bbaf79a086f674cc477cebcc1103468b91413b cli-tools/lmi/lmi_client_power.py 6f625cb011cfa67f8da8979422498d243f806107 cli-tools/lmi/lmi_client_service.py d112a87abc54c6ca218af6dfa25556cb6ef05316 cli-tools/lmi/lmi_client_shell.py fb3a29e1be1411fc2917391768c58a6865508c6b cli-tools/lmi/lmi_client_user.py aca205b91f1cfe032c2d6d7e899d908799261227 cli-tools/lmi/lmi_listener.py 6670b204a84485b6e1f8bef5dfa2893098f0a9da cli-tools/lmi/lmi_options.py 9fe18761e0b25d99c39cd3a40399bbaa243fee96 cli-tools/lmiip 200f0df48c3db46618a5b604c0a3fbc08f5f6490 cli-tools/lmipower 1cf95a5af099b4b0e6fb461383c80be1041e9a8e cli-tools/lmiservice 9d4020eb4d51e3a94ba29d2dcd128c1c1cbeb957 cli-tools/lmishell 89844d862922a3288a461e34838e3194ccf4a97b cli-tools/lmiuser 2ecff093adb46c9bbebf776fd846524c7a0185e6 lmi/lmi_address.py PRE-CREATION lmi/lmi_client_base.py PRE-CREATION lmi/lmi_client_ip.py PRE-CREATION lmi/lmi_client_power.py PRE-CREATION lmi/lmi_client_service.py PRE-CREATION lmi/lmi_client_shell.py PRE-CREATION lmi/lmi_client_user.py PRE-CREATION lmi/lmi_ip.py PRE-CREATION lmi/lmi_listener.py PRE-CREATION lmi/lmi_options.py PRE-CREATION lmi/lmi_power.py PRE-CREATION lmi/lmi_service.py PRE-CREATION lmi/lmi_shell.py PRE-CREATION lmi/lmi_user.py PRE-CREATION setup.py PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/100/diff/ Testing ------- Ran 'python setup.py install --root `pwd`/chroot' and verified that all files are installed where expected on the target system. File Attachments ---------------- Easier-to-read diff http://reviewboard-openlmi.rhcloud.com/static/media/uploaded/files/2013/0... Thanks, Stephen Gallagher

11 years, 1 month

1
2
0 / 0

Review Request 99: Build System [1/2] Remove autotools build system

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/99/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-tools Description ------- The openlmi-tools are built entirely in Python. It seems wasteful to use the heavyweight autotools build system for it. This patch and the one in review https://reviewboard-openlmi.rhcloud.com/r/100/ will replace the autotools build system with one based on Python's setuptools. Diffs ----- INSTALL a1e89e18ad20c227845f2099cb9894c799265d19 autogen.sh 4feddf0eab66bd00dd260f9a113d452c249892f5 cli-tools/lmi/makefile.am 9b92504615b628f31dbb8676cc2a46ef9e92db72 cli-tools/makefile.am 8f446c73d7bc90a3bdc8ce927b73706518d92b76 configure.ac e6f1d1ce760c6ee1502363bebf25d000f7e776dd m4/python_module.m4 bdb0cdf32e93e762eb141e656386b6f2efa1ff04 makefile.am 366817ad84e3109ffad8e5ab8efeb35e0b07d4ce Diff: http://reviewboard-openlmi.rhcloud.com/r/99/diff/ Testing ------- Testing done alongside https://reviewboard-openlmi.rhcloud.com/r/100/ Thanks, Stephen Gallagher

11 years, 1 month

1
2
0 / 0

Review Request 98: Hardware: Added Processor Cache Memory Provider

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/98/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Hardware: Added Processor Cache Memory Provider New Providers: * LMI_ProcessorCacheMemoryProvider * LMI_AssociatedProcessorCacheMemoryProvider Other Changes: * Optimized usage of string constants * Fixed wrong usage of pointers in dmidecode.c * Filled unknown mandatory fields in providers with "Unknown" value * Replaced hard coded numbers with LMI constants * Minor optimization - don't gather data which won't be used (Sorry for unrelated changes in one patch. I'll be more cautious next time!) Diffs ----- mof/LMI_Hardware.mof e655c012f542509a313e496a68ea7b85957aae6d src/hardware/CMakeLists.txt 352cebec53d9d6b877f81fd79a16219bb7e9c946 src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c PRE-CREATION src/hardware/LMI_Hardware.h e93f9fe292e82d7761114425877efc7dfc38f3b9 src/hardware/LMI_ProcessorCacheMemoryProvider.c PRE-CREATION src/hardware/LMI_ProcessorCapabilitiesProvider.c c9f7e14675de5c4eab104d02230e56afc0a4b094 src/hardware/LMI_ProcessorElementCapabilitiesProvider.c a477717789026c8522415f7114cc2070eaca22e3 src/hardware/LMI_ProcessorProvider.c c3b78e2974c9d2da3da8ff1a9595102c0c14d590 src/hardware/dmidecode.h 9a8c6c8c4cf745edc313f92150272cc9a3661007 src/hardware/dmidecode.c 14e4ac9fb21aa2467ac04c5830c9ba494c8cf80e src/hardware/sysfs.h PRE-CREATION src/hardware/sysfs.c PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/98/diff/ Testing ------- Thanks, Peter Schiffer

11 years, 1 month

1
4
0 / 0

Review Request 147: Added more check for qualifiers.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/147/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Added more check for qualifiers. Dictionary of element qualifiers can be None and we should check for it before accessing its elements. Diffs ----- tools/openlmi-doc-class2rst d93cd11ee51df8ac749bdb9bbc805ec05a46066c Diff: http://reviewboard-openlmi.rhcloud.com/r/147/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 126: openlmi-networking [1/3] Rework setting creation methods

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/126/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-networking Description ------- Rework setting creation methods Methods CreateStaticSetting and CreateDHCPSetting was renamed to CreateOrModifyStaticSetting and CreateOrModifyDynamicSetting. Both of them now can be used to modify existing setting when SettingData input argument is supplied. CreateOrModifyStaticSetting now supports multiple IP addresses, netmasks/prefixes and gateways -- it's more aligned with ExtendedStaticIPAssignmentSettingData class. Diffs ----- mof/LMI_Networking.mof fb9580105931ba03d1895279d9af561a0e5c5b46 src/LMI_IPAssignmentSettingDataProvider.c c3b632c49378233432945cbb8bd3f215425b96ae src/LMI_IPConfigurationServiceProvider.c 14af9e65aa0948955a551ac1edce1f5262a28588 src/connection.h 668460a76d97e0195e53804c29f631b095df2782 src/connection.c 7678cab5785e6b95edef103dbf3a3fa5f0612efd src/connection_nm.c a0b92223c0bc1a18a29d7bf3342cf5423c835c7f src/setting.h 514e7f0469085e73d3293a060752a0193816d9fd src/setting.c 25fa7cbad6e8d52359d0142c7210fa8e6a9d5d71 test/test_apply_connection.py 887cf7825a316ffc437eae650cb55afff02c7b0d test/test_create_destroy_connection.py b278d6acfbb509a8398926f3d6106a92adbe1dcc test/test_enable_disable_iface.py 792d3ade8a854ecea38b70ac7d73e157f59f0e53 test/test_modify_connection.py PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/126/diff/ Testing ------- Thanks, Radek Novacek

11 years, 1 month

1
1
0 / 0

Review Request 96: Unused devices: [4/5] Added tests for used/unused extents.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/96/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Added tests for used/unused extents. The tests tries to format, overwrite or delete various devices and checks, that it corresponds to our policy - used devices cannot be overwritten. Used = other device depends on it or the device is mounted. Diffs ----- test/test_unused.py PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/96/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 113: Fixed asynchronous method returning without AffectedJobElement.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/113/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Fixed asynchronous method returning without AffectedJobElement. When an async. method returns with exception or error, the associated AffectedJobElement may not exists and the test should not crash in this case. Diffs ----- test/test_base.py 2ed353629183f01f8904d0dcbd37c60173fc48a1 Diff: http://reviewboard-openlmi.rhcloud.com/r/113/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 114: Fixed AffectedStorageJobElement of CreateOrModifyLV job.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/114/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Fixed AffectedStorageJobElement of CreateOrModifyLV job. Blivet was reset in do_storage_actions(), we must re-read the device from blivet. Diffs ----- src/openlmi/storage/LMI_StorageConfigurationService.py 0abd5099b6ebb707abf95bbc6bdbc64951f3128a Diff: http://reviewboard-openlmi.rhcloud.com/r/114/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 97: Unused devices: [5/5] Remove cim2dot utility, it's part of openlmi-providers.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/97/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Remove cim2dot utility, it's part of openlmi-providers. Diffs ----- tools/cim2dot.py f8c0c9fae6d163bc2031352eb2fe6ebd7b5bc220 Diff: http://reviewboard-openlmi.rhcloud.com/r/97/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
3
0 / 0

Review Request 116: Added LMI_StorageJob.JobInParameters and .JobOutParameters properties.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/116/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Added LMI_StorageJob.JobInParameters and .JobOutParameters properties. Re-use existing _get_method_params -> make it public -> add a parameter with class name to create Diffs ----- src/openlmi/storage/JobManager.py bfd7dc64d7fc2f8eb2d95837b1b178f224ac979a Diff: http://reviewboard-openlmi.rhcloud.com/r/116/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

openlmi-devel April 2013