April 2013 - openlmi-devel - Fedora Mailing-Lists

Review Request 219: Simplify error handling of FormatProvider.get_format_for_id and get_format_for_name.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/219/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Simplify error handling of FormatProvider.get_format_for_id and get_format_for_name. With tuple (None, None) returned, following code can be used for error handling: (device, fmt) = fmtprovider.get_format_for_name(...) if not device: raise ... With None, the unpacking would not be possible. Also extend the documentation to explicitly state which device is returned. Diffs ----- src/openlmi/storage/FormatProvider.py 611e9012ea9fbecae788cb1bfa1c635ff4f16c33 Diff: http://reviewboard-openlmi.rhcloud.com/r/219/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
3
0 / 0

Review Request 218: Extend the test suite with setting expiration.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/218/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Extend the test suite with setting expiration. Diffs ----- src/openlmi/storage/LMI_StorageConfigurationService.py 8ea10fbff155d627873c71bd09890a1bb1bb5341 test/unit/config/test_unit_settings.py b33edb2e12ce9e5d4b8d41418683405af91c3182 Diff: http://reviewboard-openlmi.rhcloud.com/r/218/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

Review Request 217: Fixed Setting test suite with new logging and new Setting constructor.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/217/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Fixed Setting test suite with new logging and new Setting constructor. Diffs ----- test/unit/config/test_unit_settings.py b33edb2e12ce9e5d4b8d41418683405af91c3182 Diff: http://reviewboard-openlmi.rhcloud.com/r/217/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

Review Request 214: 'Touch' used settings in all methods.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/214/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- 'Touch' used settings in all methods. If a method uses Setting object, we must restart its timer for garbage collection. Diffs ----- src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py 4087de3e0cc3ab20fea9176a3ee43fad3cd25354 src/openlmi/storage/LMI_FileSystemConfigurationService.py 32f15febfaab9528f974081c503eb588b89c2f0a src/openlmi/storage/LMI_StorageConfigurationService.py 8ea10fbff155d627873c71bd09890a1bb1bb5341 Diff: http://reviewboard-openlmi.rhcloud.com/r/214/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

Review Request 215: Update logger test to new .conf file structure.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/215/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Update logger test to new .conf file structure. Diffs ----- test/unit/test_unit_logging.py 32e8fc8cdc0650b3b6734beeb1e689795f65ccf9 Diff: http://reviewboard-openlmi.rhcloud.com/r/215/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

Review Request 213: Let transient *Setting instances expire after 60 minutes.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/213/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Let transient *Setting instances expire after 60 minutes. Diffs ----- src/openlmi/storage/SettingManager.py 28aae91c909859fdd5feb393319da5ef50ae1ce6 src/openlmi/storage/cimom_entry.py 940ab512d528810012c941f218627c61f5a322f7 Diff: http://reviewboard-openlmi.rhcloud.com/r/213/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

Review Request 212: Added reference to SettingManager and classname to Setting.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/212/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Added reference to SettingManager and classname to Setting. It will be needed in subsequent patch. Diffs ----- src/openlmi/storage/LMI_DiskPartitionConfigurationCapabilities.py e3c31e52af4d16ba6b3bbf8c022d13952863549a src/openlmi/storage/LMI_DiskPartitionConfigurationSetting.py 3a0eebdc7caeeadbdffd8872297260d82d21d122 src/openlmi/storage/LMI_LVStorageCapabilities.py 89036187e4c4a0dc47a94be14412fa3a10e97436 src/openlmi/storage/LMI_LVStorageExtent.py 696320c9ac97ec899b0bd96097ad3befd54227ed src/openlmi/storage/LMI_MDRAIDStorageCapabilities.py d9a3cc15d1fa8db2d0e10933d0928efa11e54dfc src/openlmi/storage/LMI_MDRAIDStorageExtent.py afabf6cb0dcae68bda6df6d08a606129d6b9592f src/openlmi/storage/LMI_VGStorageCapabilities.py fe89b6d432d829f1e4d17557933a3d20117261e3 src/openlmi/storage/LMI_VGStoragePool.py 7eb061043b322d83ef7978af790685e69384d10a src/openlmi/storage/LocalFileSystemProvider.py c2cf81f1f264a399be4649bd99673c2e7f843264 src/openlmi/storage/SettingManager.py 28aae91c909859fdd5feb393319da5ef50ae1ce6 src/openlmi/storage/SettingProvider.py 40fd13cef373934b1eb8690ed6ea31079d586a6d Diff: http://reviewboard-openlmi.rhcloud.com/r/212/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

Review Request 211: Initialize TimerManager, JobManager needs it.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/211/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Initialize TimerManager, JobManager needs it. Diffs ----- src/openlmi/storage/cimom_entry.py 940ab512d528810012c941f218627c61f5a322f7 Diff: http://reviewboard-openlmi.rhcloud.com/r/211/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

Review Request 210: Fixed ParityLayoutDefault type in LMI_VGStorageCapabilities.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/210/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Fixed ParityLayoutDefault type in LMI_VGStorageCapabilities. Diffs ----- src/openlmi/storage/LMI_VGStorageCapabilities.py fe89b6d432d829f1e4d17557933a3d20117261e3 Diff: http://reviewboard-openlmi.rhcloud.com/r/210/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

Review Request 208: Add TimerManager: [5/6] Use UTC times for all wall clock times.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/208/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Use UTC times for all wall clock times. clocktime_of_last_state_change was in local time. Diffs ----- src/python/openlmi/common/JobManager.py bb6fed806de5c2e47d67d3261159a33625bfadce Diff: http://reviewboard-openlmi.rhcloud.com/r/208/diff/ Testing ------- Thanks, Jan Safranek

11 years, 2 months

1
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

openlmi-devel April 2013